Skip to content
This repository was archived by the owner on Oct 29, 2020. It is now read-only.

action (prove it) – gallery updates#834

Merged
mmwtsn merged 4 commits intoDoSomethingArchive:devfrom
mmwtsn:rb-gallery
Feb 25, 2014
Merged

action (prove it) – gallery updates#834
mmwtsn merged 4 commits intoDoSomethingArchive:devfrom
mmwtsn:rb-gallery

Conversation

@mmwtsn
Copy link
Contributor

@mmwtsn mmwtsn commented Feb 25, 2014

  1. If the campaign does not have any report back images associated with it, a single fallback image without pagination is displayed.
    default
  2. Pagination icons are now pulled in using our icon font.
    pagination
  3. Markup cleaned up.

Closes #828
Closes #829

@DFurnes
Copy link
Contributor

DFurnes commented Feb 25, 2014

We should probably leave some TODO comments next to any placeholder images we're using so that they don't get lost. Otherwise all good. +1

@DFurnes
Copy link
Contributor

DFurnes commented Feb 25, 2014

Also, looked like there was a bunch of re-indenting in the template? Just worth a double-check to make sure that was the case.

@mmwtsn
Copy link
Contributor Author

mmwtsn commented Feb 25, 2014

@TODO flags added! The indentation issue was simply Git having trouble with the diff. That commit removed a wrapping div and indented all previously nested code.

mmwtsn added a commit that referenced this pull request Feb 25, 2014
action (prove it) – gallery updates
@mmwtsn mmwtsn merged commit 5f698a2 into DoSomethingArchive:dev Feb 25, 2014
@mmwtsn mmwtsn deleted the rb-gallery branch February 25, 2014 20:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

action (prove it) – update pagination buttons action (prove it) – gallery missing fallback elements

2 participants