Closed
Conversation
…ces within and between encoded words
Contributor
Author
|
Parts of this are now handled in #214 , but this PR also addressed other issues around line folding. Did you want me to rebase or did you want to handle those some other way? |
Collaborator
|
Sorry, I only saw this after I dealt with the encoding issue. |
This was referenced Dec 5, 2025
Contributor
Author
|
replaced with #219 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #205
Changes proposed in this pull request
If the header only contains plain 7-bit ASCII then there's no point in encoding with quoted-printable. Additionally, we need to fold content to try to keep within 78 characters per line (excluding CRLF). This PR keeps ASCII as ASCII, but folds at foldable whitespace. Also, reworks encoding-words to properly encoding spaces as
"_"and to leave foldable space between blocks.encode_header_value::quoted_printableand accept the header name (to help support folding on first line)_to prevent folding within an encoded word (and to follow the RFC)render_header_value/2functions