Conversation
| : (['domoapps']); | ||
|
|
||
| return Promise.all([ | ||
| keytar.getPassword(`domoapps-oauth-access-${allScopes.join('-')}`, `${instance}-${proxyId}`), |
There was a problem hiding this comment.
Won't these just return the same thing now? Before it was the OAuth access token and OAuth refresh token. Now there doesn't seem like a unique way to distinguish between them.
There was a problem hiding this comment.
I've resolved this. However, I'm just realizing that there's a "scopes" part of the service itself (what it's named in the credential manager). What function does that serve? I've only used the domoapps scope, but I'm curious without keytar if I need to account for another scope or if it can just be saved as is
There was a problem hiding this comment.
Good catch. When you request a token and refresh token they are tied to the scopes you have requested. We don't want a token with the wrong scopes returned, because if we have the wrong scopes some requests will be blocked. We need a way store different tokens for the same instance but with different scopes. Let me know if this needs further clarification.
2 participants
replacement of keytar with configstore