Skip to content

fix(update): preserve recorded install source#262

Merged
Drswith merged 1 commit into
mainfrom
cursor/critical-correctness-bugs-c967
May 21, 2026
Merged

fix(update): preserve recorded install source#262
Drswith merged 1 commit into
mainfrom
cursor/critical-correctness-bugs-c967

Conversation

@cursor
Copy link
Copy Markdown
Contributor

@cursor cursor Bot commented May 21, 2026

Summary

  • Preserve recorded install state as the update source of truth.
  • Prevent tracked script or binary installs from being reclassified through candidate managed methods such as pip.
  • Add regression coverage for provider resolution, update command planning, and package-manager fallback behavior.

Linked Artifacts

  • Issue: n/a
  • ADR: n/a
  • OpenSpec: openspec/changes/fix-recorded-update-source
  • Discussion: n/a

Validation

  • bun run memory:check
  • bun run lint
  • bun run format:check
  • bun run typecheck
  • bun run test (if behavior changed)
  • Not run, explained below

Additional validation:

  • bun run openspec:validate
  • Main-branch reproduction: applied only the new regression tests to origin/main and confirmed the focused suite fails before the fix.

Release Intent

  • Release: patch - bug fix

Docs Updated

  • Not needed
  • docs/...
  • openspec/...
  • Follow-up issue or OpenSpec change created instead

Scope Check

  • I did not add a new ad hoc root-level Markdown file.
  • I updated the relevant issue, ADR, spec, runbook, or captured the missing doc work as follow-up.
  • I did not silently expand project scope without recording it explicitly.

Closure Check

  • Working tree was clean after commit.
  • Branch was pushed and this PR is the active delivery artifact.
  • OpenSpec change is not needed, still active by design until merge, already archived, or queued for agent-driven archive closure.
  • Release is not applicable, delegated to release automation, or verified.

Notes

On current origin/main, the added regression tests fail because recorded script installs are planned as managed updates and fallback execution can persist an unrelated managed state. This PR stops provider resolution at recorded state, only returning a managed updater for recorded managed install types, and removes the preferred-state fallback to unrelated candidate methods.

@Drswith Drswith force-pushed the cursor/critical-correctness-bugs-c967 branch from 145c246 to 25ddb5e Compare May 21, 2026 15:18
@Drswith Drswith marked this pull request as ready for review May 21, 2026 15:20
@Drswith Drswith force-pushed the cursor/critical-correctness-bugs-c967 branch from 25ddb5e to 8589115 Compare May 21, 2026 15:24
@Drswith Drswith merged commit 5b2cfbf into main May 21, 2026
9 checks passed
Drswith added a commit that referenced this pull request May 21, 2026
PR #264: archive completed OpenSpec changes from PR #261 and PR #262 after release closure.
@Drswith Drswith deleted the cursor/critical-correctness-bugs-c967 branch May 21, 2026 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant