fix: use async AMD SNP KDS fetch#750
Merged
Merged
Conversation
2c0f1db to
6c6779b
Compare
6c6779b to
84eda4f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #746.
This removes
reqwest::blockingfrom the AMD SEV-SNP KDS fallback path and uses asyncreqwest::Clientinstead, so async attestation verification no longer creates/drops a nested Tokio runtime in an async context.Changes:
AmdKdsClient, which owns the async HTTP client and boundedmokaCA/VCEK collateral cachesdstack-verifierkeep one AMD KDS client instance per verifier instance, instead of using global cache stateValidation:
cargo fmt --check --allcargo check -p sev-snp-qvl -p dstack-attest -p dstack-verifiercargo clippy -p sev-snp-qvl -p dstack-attest -p dstack-verifier -- -D warnings -D clippy::expect_used -D clippy::unwrap_used --allow unused_variablescargo test -p sev-snp-qvlcargo test -p dstack-attest --test sev_snp_verifycargo test -p dstack-verifierquote_verified=truevia KDS fallback without the Tokio runtime panic from Harden AMD SEV-SNP KDS collateral fetch (async client, timeouts, caching) #746