ci: harden build-guest manual release workflow#62
Merged
kvinwang merged 1 commit intoMay 9, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
build-guestworkflow could be dispatched against an arbitrary branch/ref and would tag and publish releases from that unreviewed ref, creating a supply-chain authorization risk.Description
releasejob that runs only when a non-emptytagis provided and the workflow is dispatched from the repository default branch.environment: releaseto require environment approval for releases and limited job permissions so thebuildjob hascontents: readand thereleasejob hascontents: write.releasejob and download artifacts produced by thebuildjob.tagwith a strict version-like regex before creating and pushing the tag and publishing the release.Testing
git diff -- .github/workflows/build-guest.ymlto verify the intended changes were applied successfully.actionlint .github/workflows/build-guest.ymlbutactionlintwas not installed in the environment, so static linting was not executed.Codex Task