Skip to content

Optimize Resource constructors#1674

Merged
josephdecock merged 3 commits intoDuendeSoftware:mainfrom
SimonCropp:Resources
Jan 28, 2025
Merged

Optimize Resource constructors#1674
josephdecock merged 3 commits intoDuendeSoftware:mainfrom
SimonCropp:Resources

Conversation

@SimonCropp
Copy link
Contributor

@SimonCropp SimonCropp commented Dec 20, 2024

  • fix the nullability of the inputs in one of the constructors
  • avoid the multiple enumerations of the inputs in 2 of the constructors
  • avoid 3x HashSet allocations for 2 of the constructors

Question: should the 3 properties be changes to be ISet instead of ICollection?

Copy link
Member

@josephdecock josephdecock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looks good, thanks! For now let's keep the types unchanged, as technically switching away from IEnumerable is a breaking change.

@josephdecock josephdecock merged commit b4daf0a into DuendeSoftware:main Jan 28, 2025
6 checks passed
@josephdecock josephdecock added this to the is-7.2.0 milestone Jan 28, 2025
@SimonCropp SimonCropp deleted the Resources branch January 28, 2025 21:23
@josephdecock josephdecock changed the title cleanup Resources Optimize Resource constructors Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/products/is IdentityServer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants