Handle case-insensitive JSON claim value types.#1769
Merged
josephdecock merged 1 commit intomainfrom Feb 6, 2025
Merged
Conversation
Updated logic in ClaimsExtensions.cs and TokenExtensions.cs to handle JSON claim value types case-insensitively, ensuring compatibility with variations like "JSON", which is the value from System.IdentityModel.Tokens.Jwt.JsonClaimValueTypes.Json. Added corresponding unit tests to verify the behavior and ensure consistent parsing of JSON claims.
bhazen
approved these changes
Feb 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates our serialization behavior so that we treat claims with either our json value type constant or the System.IdentityModel json value type constant the same. Prior to this change, we would serialize json with the System.IdentityModel as an escaped string instead of json, while our json value type constant would become json in the claims.
After this change, either constant will work to put JSON into your claims. For example, code like this in a profile service will now serialize the claims as JSON, instead of a string containing escaped quotes: