Ensure session lifetime coordination is invoked when a session expires#1784
Merged
josephdecock merged 1 commit intomainfrom Feb 11, 2025
Merged
Conversation
8ac824d to
7748171
Compare
d9410e2 to
abed8c2
Compare
josephdecock
approved these changes
Feb 10, 2025
brockallen
reviewed
Feb 10, 2025
identity-server/src/IdentityServer/Extensions/HttpContextExtensions.cs
Outdated
Show resolved
Hide resolved
abed8c2 to
e08ac15
Compare
e08ac15 to
e943fde
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What issue does this PR address?
Scenarios can exist where session lifetime coordination is enabled but a session is expired and removed prior to the cleanup job running and processing that expiration. These changes account for that scenario and implement a workaround to detect when the dotnet cookie handler removes a session and triggers the session coordination service's processing of an expired session to ensure things such as backchannel logout and removal of grants.
Important: Any code or remarks in your Pull Request are under the following terms:
If You provide us with any comments, bug reports, feedback, enhancements, or modifications proposed or suggested by You for the Software, such Feedback is provided on a non-confidential basis (notwithstanding any notice to the contrary You may include in any accompanying communication), and Licensor shall have the right to use such Feedback at its discretion, including, but not limited to the incorporation of such suggested changes into the Software. You hereby grant Licensor a perpetual, irrevocable, transferable, sublicensable, nonexclusive license under all rights necessary to incorporate and use your Feedback for any purpose, including to make and sell any products and services.
(see our license, section 7)