allow anti-forgery check to be disabled#1932
Merged
Erwinvandervalk merged 5 commits intomainfrom Apr 4, 2025
Merged
Conversation
Erwinvandervalk
force-pushed
the
ev/bff/configurable-anti-forgery-check-disable
branch
from
4381925 to
a04bfaa
Compare
Erwinvandervalk
force-pushed
the
ev/bff/configurable-anti-forgery-check-disable
branch
from
a04bfaa to
8a5ee81
Compare
josephdecock
reviewed
Apr 1, 2025
Member
josephdecock
left a comment
josephdecock
left a comment
There was a problem hiding this comment.
Do we have a fully fleshed out example of using a websocket with the BFF? Have we validated that we're not vulnerable to cross-site web socket hijacking?
Erwinvandervalk
force-pushed
the
ev/bff/configurable-anti-forgery-check-disable
branch
from
13713c3 to
06a5222
Compare
Contributor
Author
No. There are other issues with regards to websockets. I'll remove this implementation for now. |
Erwinvandervalk
force-pushed
the
ev/bff/configurable-anti-forgery-check-disable
branch
from
06a5222 to
8418ec4
Compare
Erwinvandervalk
force-pushed
the
ev/bff/configurable-anti-forgery-check-disable
branch
from
8418ec4 to
54e7c4e
Compare
Erwinvandervalk
commented
Apr 3, 2025
Co-authored-by: Joe DeCock <josephdecock@gmail.com>
Co-authored-by: Joe DeCock <josephdecock@gmail.com>
Erwinvandervalk
force-pushed
the
ev/bff/configurable-anti-forgery-check-disable
branch
from
54e7c4e to
a19ad95
Compare
damianh
approved these changes
Apr 4, 2025
Erwinvandervalk
deleted the
ev/bff/configurable-anti-forgery-check-disable
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What issue does this PR address?
The anti-forgery check can be disabled by changing the BffOptions.DisableAntiForgeryRequest method.
fixes: https://github.com/DuendeSoftware/products/issues/1732
Important: Any code or remarks in your Pull Request are under the following terms:
If You provide us with any comments, bug reports, feedback, enhancements, or modifications proposed or suggested by You for the Software, such Feedback is provided on a non-confidential basis (notwithstanding any notice to the contrary You may include in any accompanying communication), and Licensor shall have the right to use such Feedback at its discretion, including, but not limited to the incorporation of such suggested changes into the Software. You hereby grant Licensor a perpetual, irrevocable, transferable, sublicensable, nonexclusive license under all rights necessary to incorporate and use your Feedback for any purpose, including to make and sell any products and services.
(see our license, section 7)