Merged
Conversation
ed2304d to
e629c74
Compare
8b0d605 to
46e549b
Compare
fe2198e to
e0324ac
Compare
damianh
reviewed
Jun 3, 2025
8ecd79e to
b6cc7d0
Compare
ebe0307 to
e3648e4
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces the initial BFF V4 support by wiring up a new multi-frontend host, updating token‐management APIs to the new .WithAccessToken patterns, and adjusting project and package configurations.
- Add a new
Hosts.Bff.MultiFrontendhost with its HTTP test file, csproj, andBffConfig.jsonfor multi-frontend routing. - Rename token retriever methods to
*Async, update error/result handling, and switch remote‐API mappings toWithAccessToken. - Adjust launch settings (disable auto browser launch), update solution and package props for conditional versioning, and clean up project references.
Reviewed Changes
Copilot reviewed 275 out of 275 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| bff/hosts/Hosts.Bff.MultiFrontend/Hosts.Bff.MultiFrontend.http | Add HTTP snippet for weatherforecast endpoint |
| bff/hosts/Hosts.Bff.MultiFrontend/Hosts.Bff.MultiFrontend.csproj | New web project targeting net9.0 with Bff.Yarp ref |
| bff/hosts/Hosts.Bff.MultiFrontend/BffConfig.json | Initial multi-frontend JSON config with remote APIs |
| bff/hosts/Hosts.Bff.InMemory/ImpersonationAccessTokenRetriever.cs | Rename method to GetAccessTokenAsync, add cancellation token and update error/result types |
| bff/hosts/Hosts.Bff.InMemory/Extensions.cs | Replace .RequireAccessToken calls with .WithAccessToken |
| bff/hosts/Hosts.AppHost/Program.cs | Wire up BffMultiFrontend project and URLs |
| bff/hosts/Directory.Build.props | Introduce <IsBffProject> flag |
| Directory.Packages.props | Conditional package version upgrades and add hybrid caching |
Comments suppressed due to low confidence (2)
bff/hosts/Hosts.Bff.InMemory/ImpersonationAccessTokenRetriever.cs:12
- The new method signature
GetAccessTokenAsyncno longer implements theIAccessTokenRetriever.GetAccessTokencontract. Ensure the interface is updated or an explicit overload is provided to match the async variant.
public async Task<AccessTokenResult> GetAccessTokenAsync(AccessTokenRetrievalContext context, CancellationToken ct = default)
bff/hosts/Hosts.AppHost/Program.cs:23
- The
WithUrlcall is passing the same URL twice. Verify if the second argument should be a different path or host URL to avoid redundant bindings.
.WithUrl("https://app1.localhost:5005", "https://app1.localhost:5005")
5d69837 to
bb9ce93
Compare
bb9ce93 to
86a1aa5
Compare
damianh
approved these changes
Jun 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What issue does this PR address?
Important: Any code or remarks in your Pull Request are under the following terms:
If You provide us with any comments, bug reports, feedback, enhancements, or modifications proposed or suggested by You for the Software, such Feedback is provided on a non-confidential basis (notwithstanding any notice to the contrary You may include in any accompanying communication), and Licensor shall have the right to use such Feedback at its discretion, including, but not limited to the incorporation of such suggested changes into the Software. You hereby grant Licensor a perpetual, irrevocable, transferable, sublicensable, nonexclusive license under all rights necessary to incorporate and use your Feedback for any purpose, including to make and sell any products and services.
(see our license, section 7)