Tricky to use with MSVC and C++20

[s9w]

The example code doesn't compile with C++20 or above. The only mention of C++20 is a note to use tiny_utf8::u8string instead. That also fails to compile on MSVC at least since it's guarded by a check on __cplusplus. That macro is by default not set properly on MSVC, see https://docs.microsoft.com/en-us/cpp/build/reference/zc-cplusplus. Maybe that check could be rewritten in a more universal way, or at least some documentation be added about any of this.

[DuffsDevice]

Hi Sebastian, thanks for your message, I will make the adjustments to the code now :)
Cheers
Jakob

[DuffsDevice]

May I ask you to check on your side, whether it works now?
I implemented it portable, so that you don't have to add the /Zc:__cplusplus option, which I just learned about ^_^

[s9w]

Hey, thanks for the fix. I just checked and it works now.

However on MSVC warning levels 3+, a simple u8string constructions leads to a warning here:

tiny-utf8/include/tinyutf8/tinyutf8.h

Line 160 in d525494

_BitScanReverse( &value_log2 , value );

value is an uint64_t there (8 byte) and the parameter is an unsigned long (4 byte). That is just a warning though, and technically a seperate issue.

[DuffsDevice]

Super, glad to hear that! Ok, thanks for letting me now 😃
Is that fixed now by my latest commit?

[s9w]

Yeah just saw and tested it. Everything's beautiful. Thanks again.

[DuffsDevice]

Nice 👍

[DuffsDevice]

Thanks for the bug report!