Added development setup instructions to README.md#2
Conversation
|
Add a note on how to use the development version of PyGHee? |
|
Add a note on how to setup a common scripts dir (from software-layer and eessi-bot-software-layer). |
boegel
changed the title
|
Commit 81c64e6 addresses #2 (comment) |
The scripts directory contains scripts from the software-layer repo and the eessi-bot-software-layer repo. The update also mentions that you have to provide information to the location of the scripts directory via the `app.cfg` config file.
|
Commit 4e8231a addresses #2 (comment) |
Added a section that applies to after EESSI#10 has been merged.
|
|
||
| On the Linux machine set the environment variable `GITHUB_TOKEN`, e.g. | ||
| ``` | ||
| export GITHUB_TOKEN='THE_TOKEN_STRING' |
There was a problem hiding this comment.
This is actually something we shouldn't need at all.
If the bot has a private key, it can request temporary tokens by itself...
This is probably something we should open an issue for in the PyGHee repo, since that's where the requirement for $GITHUB_TOKEN comes from currently.
PyGHee should be enhanced to also support providing the location of a private key, and only fall back to requiring $GITHUB_TOKEN if no private key is provided...
- fixed specification for private key (just in app.cfg needed, no environment variable) - rewrote sections on getting repo for bot and creating app.cfg from example
First we need to install the github app (now step 3). Then we can add the `installation_id` to the bot's configuration file `app.cfg`.
trz42
changed the title
Looks good. Co-authored-by: Bob Dröge <b.e.droge@rug.nl>
bedroge
left a comment
bedroge
left a comment
There was a problem hiding this comment.
Looks good to me, huge improvement over the old page. There's still some work to be done later on, e.g. clarifying the stuff with private keys and/or tokens, but that can be done in separate PRs once this has been changed in PyGHee.
4 participants
Detailed instructions on how to set up the development instructions for the EESSI bot for the software layer.