Skip to content

Add check for the existence of EESSI_SITE_SOFTWARE_PATH in EESSI-extend #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
casparvl wants to merge 6 commits into
base: main
Choose a base branch
from
+8 −0
Open

Add check for the existence of EESSI_SITE_SOFTWARE_PATH in EESSI-extend #235

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c01fec1
Add check for the existence of the EESSI_SITE_SOFTWARE_PATH. This is …
May 21, 2026
85977e3
Use correct variable name in LmodError
May 25, 2026
7258620
Merge branch 'main' into update_site_package_behavior_eessi_extend
bedroge May 29, 2026
abb481b
Apply suggestion from @ocaisa
casparvl Jul 1, 2026
4dbadc3
EESSI-extend-easybuild.eb
Jul 2, 2026
21e4ae0
Turn into an LmodWarning. EasyBuild will create it the first time som…
Jul 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions EESSI-extend-easybuild.eb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,9 +143,17 @@ elseif eessi_site_install then
LmodError("You cannot use EESSI_SITE_INSTALL in combination with any other EESSI_*_INSTALL environment variables")
end
easybuild_installpath = os.getenv("EESSI_SITE_SOFTWARE_PATH")
-- Check that the plain EESSI_SITE_SOFTWARE_PATH exists
if not isDir(easybuild_installpath) then
LmodWarning("The location of EESSI_SITE_SOFTWARE_PATH (" .. easybuild_installpath .. ") does not exist or is not a directory")

@ocaisa ocaisa Jul 6, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
LmodWarning("The location of EESSI_SITE_SOFTWARE_PATH (" .. easybuild_installpath .. ") does not exist or is not a directory")
installpath_warning = "The location of EESSI_SITE_SOFTWARE_PATH (" .. easybuild_installpath .. ") does not exist or is not a directory. "
installpath_warning = installpath_warning .. "If you have sufficient permissions this location will be created, otherwise you will run into errors."
LmodWarning(installpath_warning)

end
Comment thread
casparvl marked this conversation as resolved.
-- Enforce accelerator subdirectory usage for site installs (only if an accelerator install is requested)
if (eessi_accelerator_target ~= nil) and (cuda_compute_capability ~= nil) and (os.getenv("EESSI_ACCELERATOR_INSTALL") ~= nil) then
easybuild_installpath = pathJoin(easybuild_installpath, eessi_accelerator_target)
-- Check that the EESSI_SITE_SOFTWARE_PATH with eessi_accelerator_target prefix exists
if not isDir(easybuild_installpath) then
LmodWarning("The easybuild install directory (" .. easybuild_installpath ..") does not exist or is not a directory")

@ocaisa ocaisa Jul 6, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
LmodWarning("The easybuild install directory (" .. easybuild_installpath ..") does not exist or is not a directory")
installpath_warning = "The location of EESSI_SITE_SOFTWARE_PATH (" .. easybuild_installpath .. ") does not exist or is not a directory. "
installpath_warning = installpath_warning .. "If you have sufficient permissions this location will be created, otherwise you will run into errors."
LmodWarning(installpath_warning)

end
end
else
-- Deal with user and project installs
Expand Down
Loading