fix: enhanced client side fastq validation#23
Open
JeremyWesthead wants to merge 10 commits into
Open
Conversation
Contributor
|
Thanks for putting the detail in here! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For after release!
Based on something Yussuf raised where it is possible to run a single illumina file through the ONT myco pipeline (and get possibly questionable results). Aim is to get a similar process deployed server side too (as this doesn't affect GUI upload), ensuring that files passed into the pipeline are from the expected instrument platform
Should be faster than existing checks while using just ~10MB RAM, and adds sanity checks for read profiles of illumina and ONT. Also validates that the files are actually valid FASTQ data rather than just have multiples of 4 lines.
Pre-built wheels should be available for the python package, so no need to rely on users having
gunzipinstalled for speed