Skip to content

test(minimax): use MiniMax-M3 in test fixtures#363

Merged
SantiagoDePolonia merged 1 commit into
ENTERPILOT:mainfrom
octo-patch:feature/upgrade-minimax-m3
Jun 2, 2026
Merged

test(minimax): use MiniMax-M3 in test fixtures#363
SantiagoDePolonia merged 1 commit into
ENTERPILOT:mainfrom
octo-patch:feature/upgrade-minimax-m3

Conversation

@octo-patch

@octo-patch octo-patch commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Summary

Update the MiniMax (minimax) provider test fixtures to reference MiniMax-M3, the current flagship model, in place of MiniMax-M2.7.

Changes

  • internal/providers/minimax/minimax_test.go: replace MiniMax-M2.7 with MiniMax-M3 in mock server responses, request payloads, and assertions.

Why

The MiniMax provider is a passthrough to the upstream API and dynamically supports any model the upstream exposes via /models. The provider does not maintain a hardcoded model list or default, so no production code needs to change to support the new model. Aligning the test fixtures with the current flagship keeps the test suite representative of typical usage.

MiniMax-M3 is the new flagship model with 512K context window, 128K max output, and image input support, available across both OpenAI-compatible and Anthropic-compatible interfaces.

Testing

  • go test ./internal/providers/minimax/... passes
  • go vet ./internal/providers/minimax/... clean

Summary by CodeRabbit

  • Tests
    • Updated minimax provider tests to validate compatibility with the latest model version.

Update minimax_test.go to use MiniMax-M3 (the current flagship model)
instead of MiniMax-M2.7 in test fixtures and assertions. The provider
is a passthrough to the upstream API and supports any model dynamically;
this change keeps the test suite aligned with the current default model
without altering provider behavior.
@coderabbitai

coderabbitai Bot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 0b5dad8b-0948-4f00-874d-5ca69e3d4496

📥 Commits

Reviewing files that changed from the base of the PR and between 60dc00c and 162d7de.

📒 Files selected for processing (1)
  • internal/providers/minimax/minimax_test.go

📝 Walkthrough

Walkthrough

The PR updates the minimax provider test file to assert MiniMax-M3 model instead of MiniMax-M2.7. All changes are model string updates across five test cases with no changes to test logic, signatures, or non-model behaviors.

Changes

MiniMax Model Version Update in Tests

Layer / File(s) Summary
Chat completion integration tests
internal/providers/minimax/minimax_test.go
Mock server responses and ChatCompletion request payloads updated to use MiniMax-M3; endpoint and authentication verification unchanged.
Temperature clamping unit tests
internal/providers/minimax/minimax_test.go
Temperature clamping unit tests (TestClampTemperature_NilTemperature, TestClampTemperature_ZeroTemperature, TestClampTemperature_PositiveTemperature) updated to reference MiniMax-M3 in ChatRequest models; clamping assertions preserved.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • ENTERPILOT/GoModel#265: Added the MiniMax provider implementation with initial tests using MiniMax-M2.7; this PR updates those test model assertions to MiniMax-M3.

Poem

🐰 A rabbit hops through test files with glee,
Swapping M2.7 for M3,
Model versions dance in the mocks,
While logic stays solid as rocks! 🎯

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'test(minimax): use MiniMax-M3 in test fixtures' accurately and concisely summarizes the main change: updating minimax provider tests to use the MiniMax-M3 model instead of MiniMax-M2.7.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@greptile-apps

greptile-apps Bot commented Jun 1, 2026

Copy link
Copy Markdown

Greptile Summary

This PR updates the MiniMax provider tests to use the newer model fixture. The main changes are:

  • Replaced MiniMax-M2.7 with MiniMax-M3 in MiniMax chat completion mock responses.
  • Updated MiniMax chat completion request fixtures and assertions.
  • Updated MiniMax temperature-clamping unit test fixtures to use MiniMax-M3.

Confidence Score: 5/5

This looks safe to merge.

  • No blocking issues found in the changed code.

Reviews (1): Last reviewed commit: "test(minimax): use MiniMax-M3 in test fi..." | Re-trigger Greptile

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@SantiagoDePolonia SantiagoDePolonia self-requested a review June 2, 2026 03:56

@SantiagoDePolonia SantiagoDePolonia left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@SantiagoDePolonia SantiagoDePolonia merged commit c34ea8d into ENTERPILOT:main Jun 2, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants