Skip to content

CMOR fixes for HadREM3-GA7-05#1062

Closed
thomascrocker wants to merge 2 commits into
mainfrom
fix_cordex_hadrem3_ga7_05
Closed

CMOR fixes for HadREM3-GA7-05#1062
thomascrocker wants to merge 2 commits into
mainfrom
fix_cordex_hadrem3_ga7_05

Conversation

@thomascrocker

@thomascrocker thomascrocker commented Mar 29, 2021

Copy link
Copy Markdown
Contributor

CMOR fixes for HadREM3-GA7-05 CORDEX data. Follows similar approach to fixes for HadGEM2-ES etc.

Before you get started

Checklist

If you make backwards incompatible changes to the recipe format:

  • Update ESMValTool and link the pull request(s) in the description

To help with the number pull requests:

@thomascrocker thomascrocker added fix for dataset Related to dataset-specific fix files cmor Related to the CMOR standard labels Mar 29, 2021
@thomascrocker thomascrocker self-assigned this Mar 29, 2021
@thomascrocker

thomascrocker commented Mar 29, 2021

Copy link
Copy Markdown
Contributor Author

My first pull request. Feel free to assign me to review any other PRs if it would be useful.

@valeriupredoi

valeriupredoi commented Mar 29, 2021

Copy link
Copy Markdown
Contributor

cheers @thomascrocker I'll have a looksee later today 👍

valeriupredoi
valeriupredoi requested changes Mar 29, 2021
View reviewed changes

@valeriupredoi valeriupredoi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two minor Codacy issues. @jvegasbsc and @zklaus will know about CORDEX, I have very limited knowledge of that dataset unfortunately

Comment thread esmvalcore/cmor/_fixes/cordex/hadrem3_ga7_05.py Outdated
Comment thread esmvalcore/cmor/_fixes/cordex/hadrem3_ga7_05.py Outdated
@thomascrocker @valeriupredoi
Apply suggestions from code review
c80b7e9 
Amended descriptions

Co-authored-by: Valeriu Predoi <valeriu.predoi@gmail.com>
@thomascrocker thomascrocker mentioned this pull request May 25, 2021
Closed
@nhsavage

nhsavage commented Jun 17, 2022

Copy link
Copy Markdown

how do we get this PR moving again please? should we do a new PR to check if it will merge to the latest head? What needs to be done to resolve the Codacy Static Code Analysis problems?

@remi-kazeroni

remi-kazeroni commented Jun 29, 2022

Copy link
Copy Markdown
Contributor

@zklaus, what are these Trello notifications that we are getting from your account? Are these accidental?

@zklaus

zklaus commented Jun 29, 2022

Copy link
Copy Markdown

Oh sorry guys, I just started using trello to organize my own ESMValTool work. I did not realize that the "Power-Up" I was using would place a backlink here.

Please disregard

PS: And now I found the switch to avoid that 🤦

@zklaus

zklaus commented Jun 29, 2022 •
edited
Loading

Copy link
Copy Markdown

@nhsavage, sorry, the trello board is intended for my personal work only, the link was placed here in error.

@sloosvel

sloosvel commented Dec 20, 2022

Copy link
Copy Markdown
Contributor

This fix got included in #1765

@sloosvel sloosvel closed this Dec 20, 2022
@bouweandela bouweandela deleted the fix_cordex_hadrem3_ga7_05 branch June 11, 2026 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@valeriupredoi valeriupredoi valeriupredoi requested changes
@zklaus zklaus Awaiting requested review from zklaus
@jvegreg jvegreg Awaiting requested review from jvegreg

Assignees

@thomascrocker thomascrocker

Labels

cmor Related to the CMOR standard fix for dataset Related to dataset-specific fix files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Dataset problem: CMORCheckError for MOHC-HadREM3-GA7-05 CORDEX data. (Wrong latitude and longitude names)

6 participants

@thomascrocker @valeriupredoi @nhsavage @remi-kazeroni @zklaus @sloosvel