Skip to content

Determine activities and institutes for CMIP6 loading CV table#107

Merged
mattiarighi merged 8 commits into
developmentfrom
development_load_CV_table
Sep 6, 2019
Merged

Determine activities and institutes for CMIP6 loading CV table#107
mattiarighi merged 8 commits into
developmentfrom
development_load_CV_table

Conversation

@sloosvel

Copy link
Copy Markdown
Contributor

Fixes #37

@sloosvel sloosvel requested review from jvegreg and zklaus June 20, 2019 09:22
@mattiarighi mattiarighi added the cmor Related to the CMOR standard label Jun 21, 2019
Comment thread esmvalcore/cmor/table.py Outdated
Comment thread esmvalcore/_config.py Outdated
Comment thread esmvalcore/_recipe.py Outdated
Comment thread esmvalcore/cmor/table.py Outdated
Comment thread esmvalcore/cmor/table.py Outdated

@zklaus zklaus left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nicely!

Comment thread esmvalcore/config-developer.yml Outdated
Comment thread esmvalcore/_config.py
@jvegreg

jvegreg commented Aug 29, 2019

Copy link
Copy Markdown
Contributor

Can the people with access to DKRZ to check that the changes in the config-developer are ok for them? I have checked BADC and it works smoothly, allowing us to mix data from CMIP and HighResMIP in the same recipe

Comment thread esmvalcore/_config.py Outdated
@valeriupredoi

Copy link
Copy Markdown
Contributor

this is very useful, totally missed it until @zklaus pointed me to it offline 🍺

@mattiarighi

mattiarighi commented Sep 6, 2019

Copy link
Copy Markdown
Contributor

@bouweandela can we merge this?
@schlunma needs it quite urgently for the automatisation of the results browser.

Thanks!

@schlunma schlunma self-requested a review September 6, 2019 08:28
@mattiarighi

Copy link
Copy Markdown
Contributor

@schlunma just merge this once tested.

@schlunma schlunma left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well for CMIP6 data sets appearing in esmvalcore/cmor/tables/cmip6/Tables/CMIP6_CV.json. However, there are models (e.g. BCC-CSM2-MR) missing in there, for which the tool will throw the following error now:

KeyError: "Dataset key institute must be specified for {...}"

Do we use an old version of the CMIP6 tables? @zklaus @jvegasbsc

@schlunma

schlunma commented Sep 6, 2019

Copy link
Copy Markdown
Contributor

Also, once this is merged the users might need to update their CMIP6 rootpath in the config-user.yml file. We also need to update the symlink on DKRZ pointing to the CMIP6 archive to one directory above the current one.

@jvegreg

jvegreg commented Sep 6, 2019

Copy link
Copy Markdown
Contributor

Do we use an old version of the CMIP6 tables? @zklaus @jvegasbsc

Yes, we have #158 to solve this. BCC-CSM2-MR is in that pull request

@mattiarighi

Copy link
Copy Markdown
Contributor

@schlunma can you update and test again after #158?

@schlunma schlunma left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CESM2-WACCM is missing, even in the new version of the tables. Other than that the PR works fine. I tested CMIP, ScenarioMIP and C4MIP data.

@mattiarighi

Copy link
Copy Markdown
Contributor

Is there any easy workaround @jvegasbsc?
Otherwise I would suggest to merge this and wait for the next release of the tables.

@zklaus

zklaus commented Sep 6, 2019

Copy link
Copy Markdown

Otherwise I would suggest to merge this and wait for the next release of the tables.

I thing that's the right way. That source_id was added on 2019-07-29, a couple more have been added since, but there is currently no release of the tables that contains this information.

@mattiarighi mattiarighi merged commit 62f5277 into development Sep 6, 2019
@mattiarighi mattiarighi deleted the development_load_CV_table branch September 6, 2019 11:20
@jvegreg

jvegreg commented Sep 6, 2019

Copy link
Copy Markdown
Contributor

Is there any easy workaround @jvegasbsc?
The easiest one is to add the institute in the recipe. I think is not a good idea to keep an extra list of those missing in the tool, as it will be a nightmare to maintain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cmor Related to the CMOR standard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Determine activity from exp

7 participants