Skip to content

Fixes for the siconc variable of CMIP6 models#1105

Merged
remi-kazeroni merged 14 commits into
mainfrom
fix_siconc_typesi
Jun 7, 2021
Merged

Fixes for the siconc variable of CMIP6 models#1105
remi-kazeroni merged 14 commits into
mainfrom
fix_siconc_typesi

Conversation

@remi-kazeroni

@remi-kazeroni remi-kazeroni commented May 6, 2021

Copy link
Copy Markdown
Contributor

Description

Closes #1104. Add missing scalar coordinate typesi for the variable siconc of CMIP6 models.


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

These fixes reuse what was done in #629.

@remi-kazeroni remi-kazeroni added fix for dataset Related to dataset-specific fix files AR6 Necessary changes for IPCC AR6 labels May 6, 2021
@remi-kazeroni remi-kazeroni added this to the v2.3.0 milestone May 6, 2021
@remi-kazeroni remi-kazeroni self-assigned this May 6, 2021
@remi-kazeroni

Copy link
Copy Markdown
Contributor Author

I moved the typesi fix into the shared fixes since it is needed for quite a few models. It's unclear to me if the value should be default or sea_ice.

def add_scalar_typesi_coord(cube, value='default'):

The few CESM2 examples with typesea or typeland are not so clear. That would help me to fix the failing test and add tests for other models.

@remi-kazeroni remi-kazeroni marked this pull request as ready for review May 17, 2021 14:11
@remi-kazeroni remi-kazeroni requested a review from jvegreg as a code owner May 17, 2021 14:11
@remi-kazeroni remi-kazeroni marked this pull request as draft May 28, 2021 14:38
@remi-kazeroni remi-kazeroni marked this pull request as ready for review May 31, 2021 08:53
@remi-kazeroni

Copy link
Copy Markdown
Contributor Author

This is now ready for review. I have refactored things a bit to share the fix accross datasets.

@jvegreg jvegreg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@remi-kazeroni remi-kazeroni merged commit cb68730 into main Jun 7, 2021
@remi-kazeroni remi-kazeroni deleted the fix_siconc_typesi branch June 7, 2021 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AR6 Necessary changes for IPCC AR6 fix for dataset Related to dataset-specific fix files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dataset problem: typesi missing for the siconc variable of some CMIP6 models

2 participants