Drop support for Python 3.8#2053
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2053 +/- ##
=======================================
Coverage 92.79% 92.79%
=======================================
Files 236 236
Lines 12484 12484
=======================================
Hits 11585 11585
Misses 899 899 |
valeriupredoi
approved these changes
May 24, 2023
valeriupredoi
left a comment
valeriupredoi
left a comment
Contributor
There was a problem hiding this comment.
yay! I had a look about and couldn't find any more mentions of Python 3.8 - I reckon we good, man - cheers 🍺
| strategy: | ||
| matrix: | ||
| python-version: ["3.8", "3.9", "3.10"] | ||
| python-version: ["3.9", "3.10"] |
Contributor
There was a problem hiding this comment.
I'll open a reminder issue to have 3.11 in here once we deploy, good reminder, dude
This was referenced May 24, 2023
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Drop support for Python 3.8 because NEP 29 recommends that we drop support for Python 3.8 on Apr 14, 2023.
Closes #1995
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: