Skip to content

Allow deprecated regridding scheme unstructured_nearest in recipe checks#2336

Merged
valeriupredoi merged 4 commits into
mainfrom
deprecate_unstructured_nearest
Feb 19, 2024
Merged

Allow deprecated regridding scheme unstructured_nearest in recipe checks#2336
valeriupredoi merged 4 commits into
mainfrom
deprecate_unstructured_nearest

Conversation

@schlunma

@schlunma schlunma commented Feb 16, 2024

Copy link
Copy Markdown
Contributor

Description

Very similar to #2324, I forgot another scheme in #2231 😬


Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@schlunma schlunma added this to the v2.11.0 milestone Feb 16, 2024
@schlunma schlunma self-assigned this Feb 16, 2024
@codecov

codecov Bot commented Feb 16, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3f610e7) 94.07% compared to head (bf3e633) 94.07%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2336   +/-   ##
=======================================
  Coverage   94.07%   94.07%           
=======================================
  Files         240      240           
  Lines       13306    13306           
=======================================
  Hits        12517    12517           
  Misses        789      789           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@valeriupredoi valeriupredoi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice and easy review, bud 😁 🍺

@valeriupredoi valeriupredoi merged commit 4d705ab into main Feb 19, 2024
@valeriupredoi valeriupredoi deleted the deprecate_unstructured_nearest branch February 19, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants