Skip to content

More lazy fixes#2450

Merged
schlunma merged 4 commits into
mainfrom
more-lazy-fixes
Jun 27, 2024
Merged

More lazy fixes#2450
schlunma merged 4 commits into
mainfrom
more-lazy-fixes

Conversation

@bouweandela

@bouweandela bouweandela commented Jun 10, 2024

Copy link
Copy Markdown
Member

Description

A few more updates to avoid realizing data when applying fixes.

Related to #674.


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@codecov

codecov Bot commented Jun 10, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.61%. Comparing base (ee16a95) to head (eebfc2f).
Report is 37 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2450      +/-   ##
==========================================
- Coverage   94.62%   94.61%   -0.01%     
==========================================
  Files         246      246              
  Lines       14055    14045      -10     
==========================================
- Hits        13299    13289      -10     
  Misses        756      756              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread esmvalcore/cmor/_fixes/cmip6/fgoals_g3.py
@bouweandela bouweandela marked this pull request as ready for review June 10, 2024 15:25
@bouweandela bouweandela added the dask related to improvements using Dask label Jun 10, 2024
@bouweandela bouweandela requested review from schlunma June 12, 2024 15:19

@valeriupredoi valeriupredoi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚽ 🍺

Comment thread esmvalcore/cmor/_fixes/cmip6/fgoals_g3.py

@schlunma schlunma left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I also have no idea why that tos fix was written like that and if we need it...

Comment thread esmvalcore/cmor/_fixes/cmip6/fgoals_g3.py
@schlunma

Copy link
Copy Markdown
Contributor

Apparently a line is too long now, could you fix that? Then I will merge

@schlunma schlunma merged commit d472381 into main Jun 27, 2024
@schlunma schlunma deleted the more-lazy-fixes branch June 27, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dask related to improvements using Dask

Projects

No open projects

Development

Successfully merging this pull request may close these issues.

3 participants