Extract time failing to get 0:00 hours of first day#259
Merged
Conversation
added 2 commits
September 18, 2019 13:43
jvegreg
added
bug
mattiarighi
approved these changes
Sep 18, 2019
bouweandela
approved these changes
Sep 26, 2019
… into fix_extract_time
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When loading
sfcWindwith mipdayfor the model- {activity: HighResMIP, dataset: CMCC-CM2-HR4, project: CMIP6, exp: highresSST-present, grid: gn, ensemble: r1i1p1f1, start_year: 1950, end_year: 2014}@sloosvel and @nperezzanon found that the first timestep was missing. After investigating, I found that it was due to an error in the
extract_timefunction that this pull request fixes, along with a new test case to test it.The error was using a strict
start < timein the constraint. It works well for most cases because models usually assign times close the middle of the interval and not at the edge, but this model was using 0:00 hours at all times