Fix ERA5 without get_frequency#2855
Merged
flicj191 merged 3 commits intoOct 14, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## era5_native6_monthly #2855 +/- ##
========================================================
- Coverage 95.46% 95.42% -0.04%
========================================================
Files 260 260
Lines 15527 15513 -14
========================================================
- Hits 14823 14804 -19
- Misses 704 709 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
10 tasks
flicj191
approved these changes
Oct 14, 2025
flicj191
left a comment
Contributor
There was a problem hiding this comment.
Ah! Thank you! makes sense
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the
get_frequencyfunction again and accept any frequency starting with1hras hourly.I also noticed that the time shift applied in the function
fix_hourly_time_coordinateassumes the time coordinate is in days, while in the tests and in the ERA5 data I have available locally/downloaded from ECWMF, it is in hours.