Skip to content

Fix ERA5 without get_frequency#2855

Merged
flicj191 merged 3 commits into
era5_native6_monthlyfrom
era5_native6_without_get_frequency
Oct 14, 2025
Merged

Fix ERA5 without get_frequency#2855
flicj191 merged 3 commits into
era5_native6_monthlyfrom
era5_native6_without_get_frequency

Conversation

@bouweandela

Copy link
Copy Markdown
Member

Remove the get_frequency function again and accept any frequency starting with 1hr as hourly.

I also noticed that the time shift applied in the function fix_hourly_time_coordinate assumes the time coordinate is in days, while in the tests and in the ERA5 data I have available locally/downloaded from ECWMF, it is in hours.

@codecov

codecov Bot commented Oct 10, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.90909% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.42%. Comparing base (9dbf26c) to head (4b58227).

Files with missing lines Patch % Lines
esmvalcore/cmor/_fixes/native6/era5.py 90.90% 4 Missing ⚠️
Additional details and impacted files
@@                   Coverage Diff                    @@
##           era5_native6_monthly    #2855      +/-   ##
========================================================
- Coverage                 95.46%   95.42%   -0.04%     
========================================================
  Files                       260      260              
  Lines                     15527    15513      -14     
========================================================
- Hits                      14823    14804      -19     
- Misses                      704      709       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@flicj191 flicj191 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! Thank you! makes sense

@flicj191 flicj191 merged commit 0b6af74 into era5_native6_monthly Oct 14, 2025
3 of 4 checks passed
@flicj191 flicj191 deleted the era5_native6_without_get_frequency branch October 14, 2025 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants