Skip to content

Various fixes for CORDEX model data#3135

Open
bouweandela wants to merge 31 commits into
mainfrom
more-cordex-fixes
Open

Various fixes for CORDEX model data#3135
bouweandela wants to merge 31 commits into
mainfrom
more-cordex-fixes

Conversation

@bouweandela

@bouweandela bouweandela commented Jun 26, 2026

Copy link
Copy Markdown
Member

Description

  • Remove height coordinate from variable snw of model COSMO-crCLIM-v1-1 as it does not make sense for this variable
  • Use standard long_name and standard variable names for coordinates for all variables from model HadREM3-GA7-05 because these are non standard
  • Set use_standard_grid: true by default for models COSMO-crCLIM-v1-1, RACMO22E, and RCA4 because these models are missing bounds on the lat/lon coordinates. This could alternatively be solved by computing the lat/lon bounds from the rotated lat/lon bounds.
  • Update the list of facets used to create the alias facet and group the datasets in the ensemble_statistics preprocessor function so they work for CORDEX data

Testing

These changes can be tested with recipe_perfmetrics_CORDEX-CMIP5.yml from ESMValGroup/ESMValTool#4199. It should also be possible to test the changes to the ensemble_statistics preprocessor function by using it in that recipe.


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

ghossh and others added 9 commits June 1, 2026 16:51
This update introduces a new section in the preprocessor documentation detailing how to regrid to standard CORDEX domains using the `target_grid` parameter. An example configuration for the `EUR-11` domain is provided, clarifying the use of domain names recognized by the `cordex` package.
@bouweandela bouweandela changed the base branch from main to target-grid-cordex-domain June 26, 2026 15:19
@bouweandela bouweandela added the fix for dataset Related to dataset-specific fix files label Jun 26, 2026
@codecov

codecov Bot commented Jun 26, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 74.35897% with 30 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.09%. Comparing base (0ac0cdf) to head (c5c2209).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...e/cmor/_fixes/cordex/mohc_hadgem2_es/cclm4_8_17.py 52.94% 8 Missing ⚠️
...xes/cordex/cnrm_cerfacs_cnrm_cm5/hadrem3_ga7_05.py 58.82% 7 Missing ⚠️
...mor/_fixes/cordex/cnrm_cerfacs_cnrm_cm5/hirham5.py 56.25% 7 Missing ⚠️
...lcore/cmor/_fixes/cordex/ichec_ec_earth/hirham5.py 0.00% 2 Missing ⚠️
...re/cmor/_fixes/cordex/ipsl_ipsl_cm5a_mr/hirham5.py 0.00% 2 Missing ⚠️
...ore/cmor/_fixes/cordex/mpi_m_mpi_esm_lr/hirham5.py 0.00% 2 Missing ⚠️
...alcore/cmor/_fixes/cordex/ncc_noresm1_m/hirham5.py 0.00% 2 Missing ⚠️

❌ Your patch check has failed because the patch coverage (74.35%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3135      +/-   ##
==========================================
- Coverage   96.25%   96.09%   -0.16%     
==========================================
  Files         273      284      +11     
  Lines       16188    16294     +106     
==========================================
+ Hits        15581    15657      +76     
- Misses        607      637      +30     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bouweandela bouweandela changed the title More cordex fixes Various fixes for CORDEX model data Jul 1, 2026
Base automatically changed from target-grid-cordex-domain to main July 2, 2026 19:58
@bouweandela bouweandela marked this pull request as ready for review July 2, 2026 20:35
@bouweandela bouweandela requested a review from ghossh July 2, 2026 20:38
@ghossh

ghossh commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

I got some of this issues from the recipe yesterday. I'm going to test this PR.

@bouweandela

Copy link
Copy Markdown
Member Author

Thanks! I'll stop working on this branch then and start a new branch for further fixes.

@ghossh

ghossh commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

You can keep making changes. I thought you finished when you put me in the reviewer. Just ping me again when you finish all changes.

@bouweandela

Copy link
Copy Markdown
Member Author

It's finished for the perfmetrics recipe, but then I tried adding another recipe plotting the models without first regridding and ran into #3145.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix for dataset Related to dataset-specific fix files

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

2 participants