Skip to content

Update CMIP6 CMOR tables to version 01.00.31 (6.8.31)#363

Merged
mattiarighi merged 2 commits into
developmentfrom
update_cmor_tables
Nov 15, 2019
Merged

Update CMIP6 CMOR tables to version 01.00.31 (6.8.31)#363
mattiarighi merged 2 commits into
developmentfrom
update_cmor_tables

Conversation

@bouweandela

@bouweandela bouweandela commented Nov 7, 2019

Copy link
Copy Markdown
Member

Tasks

  • Create an issue to discuss what you are going to do, if you haven't done so already (and add the link at the bottom)
  • This pull request has a descriptive title that can be used in a changelog
  • Circle/CI tests pass. Status can be seen below your pull request. If the tests are failing, click the link to find out why.

If you need help with any of the tasks above, please do not hesitate to ask by commenting in the issue or pull request.


Related to #329, not sure if it solves that completely though.

Closes #364

"product": "model-output",
"approx_interval": "30.00000",
"generic_levels": "olevel",
"generic_levels": "olevel olevhalf",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can anyone check this is not in any of the issues on the pcmdi github page pls? @bouweandela @zklaus @jvegasbsc

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@valeriupredoi valeriupredoi changed the title Update CMIP6 CMOR tables to version 6.8.31 Update CMIP6 CMOR tables to version 01.00.31 (6.8.31) Nov 7, 2019
@valeriupredoi

Copy link
Copy Markdown
Contributor

@bouweandela any reason why you pulled 6.8.31 and not the stable version 01.00.31?

@valeriupredoi

Copy link
Copy Markdown
Contributor

not so fast @mattiarighi there are two standing issues: the actual version itself (see my comment above) and the issue with olevhalf that is currently looked into by the PCMDI folk 🍺

@bouweandela

Copy link
Copy Markdown
Member Author

@bouweandela any reason why you pulled 6.8.31 and not the stable version 01.00.31?

6.8.31 is the latest release of the CMIP6 CMOR tables, see: https://github.com/PCMDI/cmip6-cmor-tables/releases. It contains version 01.00.31 of the CMIP6 data request.

@mattiarighi

mattiarighi commented Nov 8, 2019

Copy link
Copy Markdown
Contributor

It would be good to have a quick go at one of the CMIP6 recipes with this new version @schlunma @debe-kevin

@valeriupredoi

valeriupredoi commented Nov 8, 2019 via email

Copy link
Copy Markdown
Contributor

@valeriupredoi

valeriupredoi commented Nov 8, 2019 via email

Copy link
Copy Markdown
Contributor

@debe-kevin

debe-kevin commented Nov 8, 2019

Copy link
Copy Markdown

It would be good to have a quick go at one of the CMIP6 recipes with this new version @schlunma @debe-kevin

Hello @mattiarighi,
I tested the PR it on a rather simple recipe (consecdrydays, see below txt of the recipe).

recipe_consecdrydays_cmip6.txt

No error to report. I may run it on a more tricky recipe and let you know if I spot an error !
However, is there a specific dataset you want me to include in the recipe to test the PR ? @mattiarighi

@mattiarighi

Copy link
Copy Markdown
Contributor

If you have the cmip6 version of recipe_perfmetrics at hand it would be good to try it.
Thank you!

@mattiarighi mattiarighi added the cmor Related to the CMOR standard label Nov 11, 2019
@bouweandela

Copy link
Copy Markdown
Member Author

@debe-kevin Any news?

@debe-kevin

debe-kevin commented Nov 15, 2019

Copy link
Copy Markdown

@debe-kevin Any news?

Hello @bouweandela ,
I ran the perfmetrics recipe on CMIP6 below. The recipe requires some fix files that I will push soon. Everything worked fine after adding the updated CMIP6 CMOR table :) !

recipe_perfmetrics_cmip6.txt

@bouweandela

Copy link
Copy Markdown
Member Author

Thanks for testing! That is good news. @mattiarighi can this be merged then?

@mattiarighi

Copy link
Copy Markdown
Contributor

The recipe requires some fix files that I will push soon.

Are these fixes required because of the updated CMOR tables?
If this is the case we should merge the fix files first, otherwise this PR would prevent some recipes to run.

@debe-kevin

debe-kevin commented Nov 15, 2019

Copy link
Copy Markdown

The recipe requires some fix files that I will push soon.

Are these fixes required because of the updated CMOR tables?
If this is the case we should merge the fix files first, otherwise this PR would prevent some recipes to run.

@mattiarighi Those are fixes for missing coordinates that I needed in order to run the recipe even before including the PR commits.

@bouweandela

Copy link
Copy Markdown
Member Author

Yes, I would hope this pull request will reduce the number of fixes needed, since it removes some erroneously introduced auxiliary coordinates on fx files, see e.g. #364.

@mattiarighi mattiarighi merged commit 57bbed9 into development Nov 15, 2019
@mattiarighi mattiarighi deleted the update_cmor_tables branch November 15, 2019 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cmor Related to the CMOR standard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sftlf error in ERA-Interim data

4 participants