Skip to content

Do not fix longitude values if they are too far from valid range#636

Merged
mattiarighi merged 3 commits into
masterfrom
issue_627
May 22, 2020
Merged

Do not fix longitude values if they are too far from valid range#636
mattiarighi merged 3 commits into
masterfrom
issue_627

Conversation

@jvegreg

@jvegreg jvegreg commented May 14, 2020

Copy link
Copy Markdown
Contributor

Before you start, please read CONTRIBUTING.md.

Tasks

  • Create an issue to discuss what you are going to do, if you haven't done so already (and add the link at the bottom)
  • This pull request has a descriptive title that can be used in a changelog
  • Add unit tests
  • Public functions should have a numpy-style docstring so they appear properly in the API documentation. For all other functions a one line docstring is sufficient.
  • Circle/CI tests pass. Status can be seen below your pull request. If the tests are failing, click the link to find out why.
  • Codacy code quality checks pass. Status can be seen below your pull request. If there is an error, click the link to find out why. If you suspect Codacy may be wrong, please ask by commenting.
  • Please use yamllint to check that your YAML files do not contain mistakes
  • If you make backward incompatible changes to the recipe format, make a new pull request in the ESMValTool repository and add the link below

If you need help with any of the tasks above, please do not hesitate to ask by commenting in the issue or pull request.


Closes #627

@npgillett npgillett left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this issue.

Comment thread esmvalcore/cmor/check.py Outdated
@bouweandela bouweandela added cmor Related to the CMOR standard fix for dataset Related to dataset-specific fix files labels May 18, 2020
Comment thread esmvalcore/cmor/check.py Outdated
Comment thread esmvalcore/cmor/check.py Outdated
Comment thread esmvalcore/cmor/check.py Outdated
Co-authored-by: Bouwe Andela <b.andela@esciencecenter.nl>
@bouweandela

Copy link
Copy Markdown
Member

@mattiarighi Could you please test and merge?

@mattiarighi mattiarighi merged commit 8306a65 into master May 22, 2020
@mattiarighi mattiarighi deleted the issue_627 branch May 22, 2020 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cmor Related to the CMOR standard fix for dataset Related to dataset-specific fix files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update to check.py causes code to hang if latitudes or longitudes are set to high numbers

5 participants