Move cmor_check_data to early in preprocessing chain#743
Merged
Conversation
Contributor
|
I ran my recipe again that gave me problems in the earlier test (#727) with the new order of preprocessing. It ran through, but the units were still not correct. For the anomaly plot I would expect something with unit=1, but I get the unit of the variable that I use in the recipe. |
Contributor
|
@hb326 Since the units are set to 1 in another branch ( |
Contributor
|
Succesfully tested in combination with #727. |
jvegreg
approved these changes
Aug 17, 2020
jvegreg
left a comment
Contributor
There was a problem hiding this comment.
Already tested in the anomalies branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Moving the CMOR check of the data to earlier in the default preprocessor order, will make it possible to implement preprocessor functions that change the units of the data without using a custom_order preprocessor. People seem to run into this again and again.
Related to #708, #442, #60
Closes #741, closes #212
Tasks