Skip to content

Fixes for AWI-ESM-1-1-LR (CMIP6, piControl)#911

Merged
jvegreg merged 5 commits into
masterfrom
cmip6_fix_AWI-ESM-1-1-LR
Feb 9, 2021
Merged

Fixes for AWI-ESM-1-1-LR (CMIP6, piControl)#911
jvegreg merged 5 commits into
masterfrom
cmip6_fix_AWI-ESM-1-1-LR

Conversation

@remi-kazeroni

@remi-kazeroni remi-kazeroni commented Dec 17, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Before you start, please read our contribution guidelines.

Tasks

  • Create an issue to discuss what you are going to do, if you haven't done so already (and add the link at the bottom)
  • This pull request has a descriptive title that can be used in a changelog
  • Add unit tests
  • Public functions should have a numpy-style docstring so they appear properly in the API documentation. For all other functions a one line docstring is sufficient.
  • If writing a new/modified preprocessor function, please update the documentation
  • Circle/CI tests pass. Status can be seen below your pull request. If the tests are failing, click the link to find out why.
  • Codacy code quality checks pass. Status can be seen below your pull request. If there is an error, click the link to find out why. If you suspect Codacy may be wrong, please ask by commenting.
  • Please use yamllint to check that your YAML files do not contain mistakes
  • If you make backward incompatible changes to the recipe format, make a new pull request in the ESMValTool repository and add the link below

If you need help with any of the tasks above, please do not hesitate to ask by commenting in the issue or pull request.

Closes #910

@remi-kazeroni remi-kazeroni added the fix for dataset Related to dataset-specific fix files label Dec 17, 2020
@remi-kazeroni remi-kazeroni changed the title fix for all vars Fixes for AWI-ESM-1-1-LR (CMIP6, piControl) Dec 17, 2020
@remi-kazeroni remi-kazeroni marked this pull request as ready for review January 25, 2021 16:10
jvegreg
jvegreg approved these changes Jan 26, 2021
View reviewed changes

@jvegreg jvegreg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@jvegreg jvegreg self-requested a review January 26, 2021 09:56
jvegreg
jvegreg requested changes Jan 26, 2021
View reviewed changes

@jvegreg jvegreg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please fix the tests?

@remi-kazeroni

remi-kazeroni commented Jan 26, 2021

Copy link
Copy Markdown
Contributor Author

Can you please fix the tests?

Thanks for reviewing. The tests are now fixed.

@valeriupredoi

valeriupredoi commented Feb 8, 2021

Copy link
Copy Markdown
Contributor

nice one cheers @remi-kazeroni 🍺 @jvegasbsc I am okay with merging this and including it in release even if there's an AllVars fix, do you agree?

@valeriupredoi valeriupredoi mentioned this pull request Feb 8, 2021
Closed
@jvegreg jvegreg merged commit 7cc636f into master Feb 9, 2021
@jvegreg jvegreg deleted the cmip6_fix_AWI-ESM-1-1-LR branch February 9, 2021 14:28
jvegreg pushed a commit that referenced this pull request Feb 9, 2021
@remi-kazeroni
Fixes for AWI-ESM-1-1-LR (CMIP6, piControl) (#911)
c773878 
* fix for all vars

* test created

* fix failing tests

* fix codacy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jvegreg jvegreg jvegreg approved these changes
@valeriupredoi valeriupredoi valeriupredoi approved these changes

Assignees

@LisaBock LisaBock

@remi-kazeroni remi-kazeroni

Labels

fix for dataset Related to dataset-specific fix files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Dataset problem: AWI-ESM-1-1-LR wrong reference year

4 participants

@remi-kazeroni @valeriupredoi @jvegreg @LisaBock