Handling of Fx variables as regular variables for CMIP5 and CMIP6 (simple, no CMOR checks)#1065
Closed
valeriupredoi wants to merge 14 commits into
Closed
Handling of Fx variables as regular variables for CMIP5 and CMIP6 (simple, no CMOR checks)#1065valeriupredoi wants to merge 14 commits into
valeriupredoi wants to merge 14 commits into
Conversation
Contributor
Author
|
OK guys, compacted code, fixed all tests, tested extensively with CMIP5 and 6 -> this is ready for your consideration 🍺 @bouweandela @zklaus @mattiarighi |
Contributor
Author
|
whereas #1037 can wait (it's big and ugly 😁 ) I reckon this one should have some priority - people are already running CMIP6 data that needs fx files (like @tillku ) - when you have time @bouweandela and @mattiarighi 🍺 |
This was referenced May 22, 2019
Member
|
Please re-open this pull request in the ESMValTool Core repository. You can do so by pushing this branch to that repository, using the following instructions. First add the repository with git remote add esmvalcore git@github.com:esmvalgroup/esmvalcoreor git remote add esmvalcore https://github.com/esmvalgroup/esmvalcoreif you're not using ssh to connect to GitHub. Next upload the branch with and open a pull request here |
Contributor
Author
|
ported to ESMValGroup/ESMValCore#18 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The simplified version of #1037 (there are no CMOR checks and fixes for fx vars in this PR) - basically uses the standard input and output data structures for FX variables as well, removing the need for special fx I/O; tested with CMIP5 and CMIP6 data; note that now if a variable needs fx files for diagnostic they are specified slightly more complex:
since for CMIP5 this was not needed because mip=fx always for fx variables in CMIP5; a bit different for CMIP6 though.
@bouweandela can u pls have a look at the recipe tests that are systematically failing? I fail to see why this is happening. Cheers, dude 🍺