Variable alias management#950
Conversation
bouweandela
left a comment
There was a problem hiding this comment.
Code looks mostly fine to me, can you fix the Codacy issues and tests?
Why is there a new configuration file needed? Wouldn't it make more sense to put this in config-developer.yml?
|
Please re-open this pull request in the ESMValTool Core repository. You can do so by pushing this branch to that repository, using the following instructions. First add the repository with git remote add esmvalcore git@github.com:esmvalgroup/esmvalcoreor git remote add esmvalcore https://github.com/esmvalgroup/esmvalcoreif you're not using ssh to connect to GitHub. Next upload the branch with and open a pull request here |
|
@jvegasbsc Are you still planning to move this to the ESMValCore repository? |
|
Yes, I should. |
|
@jvegasbsc - Will this go into the ESMvalcore repository soon? I am revisiting the issue #1077 and it looks like this fix will take care of the alias names for soil moisture (in UKESM). |
|
Please move this to the core. |
|
Is there an update on this? I need this to work for some UKESM data I am processing. Please advice. |
|
There is currently an issue reported in #1593 that may affect this, so I think I will redo this work soon |
|
Thanks, @jvegasbsc |
|
Ported to ESMValGroup/ESMValCore#595 |
Generalize the alias management for variables that are known by different short names depending on the project.
All projects will now check the knwon alias for a variable to get the CMOR info (custom vars included)
Automation of alias contrsuction is not advisable because we can face problems like siconc and siconca sharing the standard name.
See discussion in #857