Skip to content

Variable alias management#950

Closed
jvegreg wants to merge 2 commits into
masterfrom
version2_variable_alias
Closed

Variable alias management#950
jvegreg wants to merge 2 commits into
masterfrom
version2_variable_alias

Conversation

@jvegreg

@jvegreg jvegreg commented Mar 8, 2019

Copy link
Copy Markdown
Contributor

Generalize the alias management for variables that are known by different short names depending on the project.

All projects will now check the knwon alias for a variable to get the CMOR info (custom vars included)

Automation of alias contrsuction is not advisable because we can face problems like siconc and siconca sharing the standard name.

See discussion in #857

@bouweandela bouweandela left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks mostly fine to me, can you fix the Codacy issues and tests?

Why is there a new configuration file needed? Wouldn't it make more sense to put this in config-developer.yml?

@bouweandela

Copy link
Copy Markdown
Member

Please re-open this pull request in the ESMValTool Core repository. You can do so by pushing this branch to that repository, using the following instructions.

First add the repository with

git remote add esmvalcore git@github.com:esmvalgroup/esmvalcore

or

git remote add esmvalcore https://github.com/esmvalgroup/esmvalcore

if you're not using ssh to connect to GitHub.

Next upload the branch with

git push esmvalcore your_branch

and open a pull request here

@bouweandela

Copy link
Copy Markdown
Member

@jvegasbsc Are you still planning to move this to the ESMValCore repository?

@jvegreg

jvegreg commented Sep 6, 2019

Copy link
Copy Markdown
Contributor Author

Yes, I should.

@rswamina

Copy link
Copy Markdown
Contributor

@jvegasbsc - Will this go into the ESMvalcore repository soon? I am revisiting the issue #1077 and it looks like this fix will take care of the alias names for soil moisture (in UKESM).

@mattiarighi

Copy link
Copy Markdown
Contributor

Please move this to the core.

@mattiarighi mattiarighi changed the base branch from version2_development to master January 3, 2020 18:01
@rswamina

Copy link
Copy Markdown
Contributor

Is there an update on this? I need this to work for some UKESM data I am processing. Please advice.

@jvegreg

jvegreg commented Mar 27, 2020

Copy link
Copy Markdown
Contributor Author

There is currently an issue reported in #1593 that may affect this, so I think I will redo this work soon

@rswamina

Copy link
Copy Markdown
Contributor

Thanks, @jvegasbsc

@jvegreg

jvegreg commented Mar 31, 2020

Copy link
Copy Markdown
Contributor Author

Ported to ESMValGroup/ESMValCore#595

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants