Fix bug introduced in #400 in method matching for AsyncCallbackJsonWebHandler#405
Merged
mathieucarbou merged 1 commit intomainfrom Mar 14, 2026
Merged
Fix bug introduced in #400 in method matching for AsyncCallbackJsonWebHandler#405mathieucarbou merged 1 commit intomainfrom
mathieucarbou merged 1 commit intomainfrom
Conversation
mathieucarbou
requested review from
Copilot,
me-no-dev,
vortigont and
willmmiles
There was a problem hiding this comment.
Pull request overview
Fixes a regression from #400 affecting HTTP method matching in AsyncCallbackJsonWebHandler by ensuring the handler’s _method mask is set to the intended set of HTTP verbs.
Changes:
- Removes the previously defined
JsonHandlerMethodsconstant used for method masks. - Inlines the HTTP method bitmask directly into both
AsyncCallbackJsonWebHandlerconstructors (ArduinoJson v6 and non-v6 branches).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
@willmmiles : FYI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #404