Clean up#47
Merged
Merged
Conversation
marcosmilzo
reviewed
Nov 22, 2017
marcosmilzo
left a comment
marcosmilzo
left a comment
Contributor
There was a problem hiding this comment.
That's what they call a real clean up!
| analyzer = SentimentIntensityAnalyzer() | ||
| sentiment = analyzer.polarity_scores(sentence) | ||
| return sentiment | ||
| from vaderSentiment.vaderSentiment import SentimentIntensityAnalyzer |
| @@ -100,6 +100,7 @@ Twisted==17.5.0 | |||
| twitter==1.17.1 | |||
| Unidecode==0.4.21 | |||
| urllib3==1.22 | |||
Contributor
There was a problem hiding this comment.
Should we double check all the packages to remove any useless one?
Contributor
Author
There was a problem hiding this comment.
yes, good idea. will do that!
Contributor
Author
There was a problem hiding this comment.
Just checked, the twitter package is the only one that is not required......
The remaining list is the bare minimum packages required for the reading machine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A simple clean up for deployment.