Update debugging flow#1140
Merged
rahulsprajapati merged 16 commits intoAug 2, 2018
Merged
Conversation
Signed-off-by: Riddhesh Sanghvi <riddheshsanghvi96@gmail.com>
Signed-off-by: Riddhesh Sanghvi <riddheshsanghvi96@gmail.com>
Signed-off-by: Riddhesh Sanghvi <riddheshsanghvi96@gmail.com>
Signed-off-by: Riddhesh Sanghvi <riddheshsanghvi96@gmail.com>
Signed-off-by: Riddhesh Sanghvi <riddheshsanghvi96@gmail.com>
Signed-off-by: Riddhesh Sanghvi <riddheshsanghvi96@gmail.com>
Signed-off-by: Riddhesh Sanghvi <riddheshsanghvi96@gmail.com>
Signed-off-by: Riddhesh Sanghvi <riddheshsanghvi96@gmail.com>
Signed-off-by: Riddhesh Sanghvi <riddheshsanghvi96@gmail.com>
Signed-off-by: Riddhesh Sanghvi <riddheshsanghvi96@gmail.com>
This was referenced Aug 2, 2018
Signed-off-by: Riddhesh Sanghvi <riddheshsanghvi96@gmail.com>
Signed-off-by: Riddhesh Sanghvi <riddheshsanghvi96@gmail.com>
rahulsprajapati
suggested changes
Aug 2, 2018
|
|
||
| include_once(__DIR__ . '/../../php/class-ee.php'); | ||
| include_once(__DIR__ . '/../../php/utils.php'); | ||
| define('EE_ROOT',__DIR__ . '/../..'); |
Contributor
There was a problem hiding this comment.
Add a space as you're doing it other places, after brackets.
ref: https://github.com/EasyEngine/easyengine/pull/1140/files#diff-8a50a8f3567ab9a03107fd86eeaf827eR10
| include_once(__DIR__ . '/../../php/utils.php'); | ||
| define('EE_ROOT',__DIR__ . '/../..'); | ||
|
|
||
| include_once(EE_ROOT . '/php/class-ee.php'); |
Contributor
There was a problem hiding this comment.
same for this, use one type of include_once. Here you've used brackets and not for other places.
i.e: https://github.com/EasyEngine/easyengine/pull/1140/files#diff-8a50a8f3567ab9a03107fd86eeaf827eR28
Also check require_once.
| include_once "$logger_dir/Base.php"; | ||
|
|
||
| foreach ( $iterator as $filename ) { | ||
| if ( '.php' !== substr( $filename, - 4 ) ) { |
Contributor
There was a problem hiding this comment.
I think here you need the extension so you can use pathinfo for that.
pathinfo( $filename, PATHINFO_EXTENSION );
| return true; | ||
| } | ||
| EE::error( $launch->stderr ); | ||
| return EE::exec( $command, true, true, true ); |
Contributor
There was a problem hiding this comment.
what's the purpose of this? 🤔 Looks like the another wrapper of EE::exec()
I don't see anything related to the container in this function.
Signed-off-by: Riddhesh Sanghvi <riddheshsanghvi96@gmail.com>
mrrobot47
force-pushed
the
update/debugging
branch
from
41ede97 to
7352e7a
Compare
Signed-off-by: Riddhesh Sanghvi <riddheshsanghvi96@gmail.com>
Signed-off-by: Riddhesh Sanghvi <riddheshsanghvi96@gmail.com>
rahulsprajapati
approved these changes
Aug 2, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1139
Breaking changes. Need functional call changes in following post this:
https://github.com/easyengine/site-command/
https://github.com/easyengine/site-wp-command/
https://github.com/easyengine/cron-command/