Skip to content

Add missing policies to PolicyDefinition - #281

Merged
zidad merged 33 commits into
EasyNetQ:masterfrom
inikulshin:policydef
Dec 11, 2023
Merged

Add missing policies to PolicyDefinition#281
zidad merged 33 commits into
EasyNetQ:masterfrom
inikulshin:policydef

Conversation

@inikulshin

@inikulshin inikulshin commented Dec 10, 2023

Copy link
Copy Markdown
Contributor

Based on
image

zidad
zidad previously approved these changes Dec 11, 2023
View reviewed changes
@zidad

zidad commented Dec 11, 2023

Copy link
Copy Markdown
Member

Wow, many thanks!

@zidad zidad self-assigned this Dec 11, 2023
@inikulshin

inikulshin commented Dec 11, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Wow, many thanks!

However, the PR breaks public API.
I'll make JsonStringEnumConverterEx internal, but all other changes are mandatory.

Upd: @zidad do you want me to fix EasyNetQ.Management.Client.approved.txt?

@inikulshin

inikulshin commented Dec 11, 2023

Copy link
Copy Markdown
Contributor Author

Wow, many thanks!

@zidad sorry for many aftercommits (I hope you'll squash all them in merge). Can you recheck and review it?

@inikulshin

inikulshin commented Dec 11, 2023

Copy link
Copy Markdown
Contributor Author

Now it fails because of the last EOL symbol in EasyNetQ.Management.Client.approved.txt.
But I can't fix it from the browser, like all previous commits I did 😠

@zidad
zidad self-requested a review December 11, 2023 19:56
@inikulshin

inikulshin commented Dec 11, 2023

Copy link
Copy Markdown
Contributor Author

Hallelujah!

I'll make some more PRs (at least 1) soon.
Will it be possible to create a new tag and publish new NuGet package soon?

Pliner
Pliner approved these changes Dec 11, 2023
View reviewed changes

@Pliner Pliner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Pliner

Pliner commented Dec 11, 2023

Copy link
Copy Markdown
Member

Hallelujah!

I'll make some more PRs (at least 1) soon. Will it be possible to create a new tag and publish new NuGet package soon?

Sure. We will be able to release a new dev version available on NuGet.

@zidad
zidad merged commit 7ca648c into EasyNetQ:master Dec 11, 2023
@Pliner

Pliner commented Dec 11, 2023

Copy link
Copy Markdown
Member

I have push a new tag, but GA is failed https://github.com/EasyNetQ/EasyNetQ.Management.Client/actions/runs/7173143825/job/19531930696.

Need to generate a new key...

@Pliner

Pliner commented Dec 11, 2023

Copy link
Copy Markdown
Member

https://www.nuget.org/packages/EasyNetQ.Management.Client/3.0.0-alpha3

@inikulshin
inikulshin deleted the policydef branch December 13, 2023 16:11
sungam3r
sungam3r reviewed Dec 30, 2024
View reviewed changes
Comment thread Source/EasyNetQ.Management.Client/Serialization/JsonStringEnumConverterEx.cs
// https://github.com/dotnet/runtime/issues/31081#issuecomment-848697673
internal class JsonStringEnumConverterEx<TEnum> : JsonConverter<TEnum> where TEnum : struct, Enum
{
private readonly Dictionary<TEnum, string> _enumToString = new Dictionary<TEnum, string>();

@sungam3r sungam3r Dec 30, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All fields and constructor can be made static.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zidad zidad zidad approved these changes
@Pliner Pliner Pliner approved these changes
@micdenny micdenny Awaiting requested review from micdenny micdenny is a code owner
@luigiberrettini luigiberrettini Awaiting requested review from luigiberrettini luigiberrettini is a code owner
+1 more reviewer
@sungam3r sungam3r sungam3r left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@zidad zidad

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@inikulshin @zidad @Pliner @sungam3r