Skip to content

Add a Change Tileset testcase and update the Testgames 2000 and 2003#41

Merged
Ghabry merged 7 commits intoEasyRPG:masterfrom
Mimigris:sorbet
Nov 19, 2023
Merged

Add a Change Tileset testcase and update the Testgames 2000 and 2003#41
Ghabry merged 7 commits intoEasyRPG:masterfrom
Mimigris:sorbet

Conversation

@Mimigris
Copy link
Contributor

TestGame 2000:

  • Add the following EasyRPG RTP assets for use in testcases: CharSet/People2 (for use in the Transitions test to no longer rely on a Don Miguel RTP asset), ChipSet/Dungeon, ChipSet/Exterior, ChipSet/Interior, ChipSet/Ship, ChipSet/World2 (for use in the Change Tileset testcase).
  • Update the following EasyRPG RTP assets to match with the ones currently present: CharSet/Chara1 (Actor1), GameOver/GameOver. Also update the asset FaceSet/Chara1 since it uses graphics from the EasyRPG RTP.
  • Remove the following unused assets: Title/Title3, Title/Title4. Keeping the assets Title/Title1 since used as a cover for the game on the Android version and keeping the System2 and BattleWeapon folders since used to be used as a way to detect the engine in the past.
  • Rename the assets ChipSet/Basis to ChipSet/World and ChipSet/Basis-flat to ChipSet/World-flat.
  • Rename some maps in the maptree to avoid having maps with the same name when looking at it.
  • Add tests to the Music Playing testcase to play non-existing music, as well as one to check the Midi Play Location and if the Current BGM has completed a loop.
  • Add tests to set a variable to Money, Party Size, Save count, Battle count, Win count, Loss count, Escape count, Item is Equipped, Item 0 is Equipped (to check if an empty slot is present) to the Control Variables testcase, as well as a test battle to test to update the win, loss and escape counts.
  • Add a test to set a variable to the Timer's Remaining Time in the Timer Operations testcase.
  • Add a Change tileset testcase.
  • Add a test to change the font used in the Change System testcase, as well as one to test the text there.

TestGame 2003:

  • Remove the placeholder ultimate_rt_eb.dll file that was used to detect the game and replace it by an EasyRPG.ini file.
  • Fix some typos for the battle lines.

Mimigris added 7 commits June 19, 2023 21:17
Fixed some typos
Removed the ultimate_rt_eb.dll for a EasyRPG.ini file
- Add test to play an empty and inexisting music, as well as Midi Play Location and Current BGM has completed a loop to Music Playing
- Add Control Variables: Timer's Remaining Time to Timer Operations
- Add Control Variables: Money, Party Size, Save, Battle, Win, Loss and Escape Count to Variable operations as well as a test battle there
- Add Control Variables: Item X is equipped and Item 0 is equipped to Equipment
2k
- Remove unused Title pictures Title3 and Title4 (keeping Title1 due to it being displayed as the cover when playing on mobile)
- Update the GameOver picture and Chara1 CharSet with the new versions from the EasyRPG RTP
- Add new ChipSets in plan for a Change Tileset test and rename old ChipSets

NOTE: keeping System2 and BattleWeapon content in 2k due to the presence of said folders being used in the past to detect the engine, can still be useful in case of a regression
- Add Change tileset test and the assets needed for it
- Add CharSet/People2 for use in the transition test instead of requesting Don's exclusive RTP assets
- Rename some maps to match with their master test
@Ghabry
Copy link
Member

Ghabry commented Nov 19, 2023

Thanks for the new testcase and all the other maintenance work.

Quick question: You added ChipSet/World2.png. Is this used in the ChipSet test? If not please remove it.

@Mimigris
Copy link
Contributor Author

Quick question: You added ChipSet/World2.png. Is this used in the ChipSet test? If not please remove it.

Related to Player #3046, I've added in the Change Tileset testcase the display of events using graphics from the ChipSet, and to properly be able to check this, I needed to have tiles having the same graphics but different transparency properties, so I've made an edited version of the World ChipSet and used it for that, so World2 is used.

@Ghabry Ghabry merged commit 06cefa1 into EasyRPG:master Nov 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants