Fix so new connections are only added as backend connections after they are 'ready' - #133
Merged
Conversation
…e 'ready' New connections are added to the backend connections here: https://github.com/Ecdar/Ecdar-GUI/blob/9ca653b7817706f132d88c8a773a0487e99c6038/src/main/java/ecdar/backend/BackendDriver.java#L153 But that is before the `updateComponents` query has completed, so a query can take the backend before it is ready. This results in a bunch of non-deterministic errors when executing queries, one being the `UNAVAILABLE: io exception` error. The backend should only be added on the `onCompleted` as is already done: https://github.com/Ecdar/Ecdar-GUI/blob/9ca653b7817706f132d88c8a773a0487e99c6038/src/main/java/ecdar/backend/BackendDriver.java#L171 After this small fix you can spam queries to your heart's content with no issues :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New connections are added to the backend connections here:
Ecdar-GUI/src/main/java/ecdar/backend/BackendDriver.java
Line 153 in 9ca653b
But that is before the
updateComponentsquery has completed, so a query can take the backend before it is ready. This results in a bunch of non-deterministic errors when executing queries, one being theUNAVAILABLE: io exceptionerror.The backend should only be added on the
onCompletedas is already done:Ecdar-GUI/src/main/java/ecdar/backend/BackendDriver.java
Line 171 in 9ca653b
After this small fix you can spam queries to your heart's content with no issues :)