fix(mobile): add visualPlans to threadActivity test fixture#35
Closed
Ecko95 wants to merge 1 commit into
Closed
Conversation
PR #30 (visual-plan) added visualPlans as a required field on the decoded OrchestrationThread type, but the mobile makeThread test fixture never set it, leaving @t3tools/mobile red on typecheck on gits. One-line fixture fix. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
github-actions
Bot
added
vouch:trusted
Owner
Author
|
Superseded — gits commit 9de0625 ("test: fix stale fixtures/expectations the newly-enabled CI surfaced") already added |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #30 (visual-plan) added
visualPlansas a required field on the decodedOrchestrationThreadtype, but the mobilemakeThreadtest fixture inthreadActivity.test.tsnever set it — leaving@t3tools/mobilered on typecheck ongits("Two different types with this name exist…visualPlans" /undefinednot assignable). One-line fixture fix:visualPlans: [].Verification
@t3tools/mobiletypecheck: exit 0 (was failing).threadActivity.test.ts: 2/2 pass.bun typecheck --force): 14/14 green.🤖 Generated with Claude Code