test: fix two stale test expectations blocking ci.yml#36
Merged
Conversation
Both pre-existing on gits, unrelated to any in-flight feature work: - CodexAdapter.test: visual-plan (PR #30) wired visualPlanMcpUrl into the codex spawn input; add it to the expected object. - DesktopAppIdentity.test: T3 Code→GITS rebrand (APP_BASE_NAME="GITS"); the commit-override path now yields "GITS (Alpha)". The legacy userData PATH expectation stays "T3 Code (Alpha)" (migration back-compat). Full suite: 14/14 packages green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
github-actions
Bot
added
vouch:trusted
Ecko95
force-pushed
the
fix/stale-test-expectations
branch
from
June 21, 2026 10:12
7f642cd to
b8c0144
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two pre-existing test failures the newly-enabled CI (GitHub-hosted runners, PR #33) surfaced on
gits— both stale expectations from already-merged work, unrelated to any in-flight feature:apps/server/.../CodexAdapter.test.ts— visual-plan (PR feat(visual-plan): native builder.io visual-plan replica — Phase 1 (all 3 providers) #30) wiredvisualPlanMcpUrlinto the codex spawn input; the test'sexpectedobject wasn't updated. Added it.apps/desktop/.../DesktopAppIdentity.test.ts— the T3 Code→GITS rebrand (APP_BASE_NAME = "GITS") makes the commit-override path'sdisplayName="GITS (Alpha)". Updated thesetName/applicationNameexpectations. The legacy userData path assertion intentionally stays"T3 Code (Alpha)"(migration back-compat).Verification
turbo run test --continue).🤖 Generated with Claude Code