Skip to content

Conversation

@kitlangton
Copy link
Contributor

@kitlangton kitlangton commented Nov 21, 2025

Summary

  • add backward cron traversal with shared lookup tables and last-boundary resets
  • align DST handling while walking backward and add reverse sequence iterator
  • expand cron prev/next symmetry tests, DST overlap coverage, step/range backward cases, month/year wrap, and add changeset

Context

Based on @tmcw's fork branch https://github.com/tmcw/effect/tree/cron-prev ; rebased on main and tightened tests/edge cases.
Closes #5666.

Testing

  • pnpm vitest packages/effect/test/Cron.test.ts

@changeset-bot
Copy link

changeset-bot bot commented Nov 21, 2025

🦋 Changeset detected

Latest commit: 42e9d0d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 36 packages
Name Type
effect Minor
@effect/cli Major
@effect/cluster Major
@effect/experimental Major
@effect/opentelemetry Major
@effect/platform-browser Major
@effect/platform-bun Major
@effect/platform-node-shared Major
@effect/platform-node Major
@effect/platform Major
@effect/printer-ansi Major
@effect/printer Major
@effect/rpc Major
@effect/sql-clickhouse Major
@effect/sql-d1 Major
@effect/sql-drizzle Major
@effect/sql-kysely Major
@effect/sql-libsql Major
@effect/sql-mssql Major
@effect/sql-mysql2 Major
@effect/sql-pg Major
@effect/sql-sqlite-bun Major
@effect/sql-sqlite-do Major
@effect/sql-sqlite-node Major
@effect/sql-sqlite-react-native Major
@effect/sql-sqlite-wasm Major
@effect/sql Major
@effect/typeclass Major
@effect/vitest Major
@effect/workflow Major
@effect/ai Major
@effect/ai-amazon-bedrock Major
@effect/ai-anthropic Major
@effect/ai-google Major
@effect/ai-openai Major
@effect/ai-openrouter Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@effect-bot effect-bot changed the base branch from main to next-minor November 21, 2025 21:08
@kitlangton kitlangton requested a review from fubhy November 21, 2025 21:31
@kitlangton
Copy link
Contributor Author

@copilot tell me I'm beautiful

Copy link

Copilot AI commented Nov 21, 2025

@kitlangton I've opened a new pull request, #5787, to work on those changes. Once the pull request is ready, I'll request review from you.

@effect-bot effect-bot force-pushed the next-minor branch 10 times, most recently from 6c3c7b6 to a75f668 Compare November 27, 2025 04:41
@effect-bot effect-bot force-pushed the next-minor branch 5 times, most recently from 7922be1 to 8fa279a Compare January 6, 2026 19:47
@tmcw
Copy link

tmcw commented Jan 6, 2026

Any chance this can get merged? Would love to drop another dependency in favor of Effect.

@kitlangton
Copy link
Contributor Author

@fubhy YOU HAVE DECEIVED US.

@fubhy
Copy link
Member

fubhy commented Jan 7, 2026

OKOK I AM ON IT!

Copy link
Member

@fubhy fubhy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to team Cron

@github-project-automation github-project-automation bot moved this from Discussion Ongoing to Needs merge in PR Backlog Jan 7, 2026
@fubhy fubhy merged commit dd410e0 into next-minor Jan 7, 2026
11 checks passed
@github-project-automation github-project-automation bot moved this from Needs merge to Done in PR Backlog Jan 7, 2026
@fubhy fubhy deleted the cron-prev-polish branch January 7, 2026 08:18
effect-bot pushed a commit that referenced this pull request Jan 9, 2026
Co-authored-by: Tom MacWright <tom@macwright.com>
Co-authored-by: Sebastian Lorenz <fubhy@fubhy.com>
effect-bot pushed a commit that referenced this pull request Jan 14, 2026
Co-authored-by: Tom MacWright <tom@macwright.com>
Co-authored-by: Sebastian Lorenz <fubhy@fubhy.com>
effect-bot pushed a commit that referenced this pull request Jan 16, 2026
Co-authored-by: Tom MacWright <tom@macwright.com>
Co-authored-by: Sebastian Lorenz <fubhy@fubhy.com>
effect-bot pushed a commit that referenced this pull request Jan 18, 2026
Co-authored-by: Tom MacWright <tom@macwright.com>
Co-authored-by: Sebastian Lorenz <fubhy@fubhy.com>
effect-bot pushed a commit that referenced this pull request Jan 19, 2026
Co-authored-by: Tom MacWright <tom@macwright.com>
Co-authored-by: Sebastian Lorenz <fubhy@fubhy.com>
effect-bot pushed a commit that referenced this pull request Jan 20, 2026
Co-authored-by: Tom MacWright <tom@macwright.com>
Co-authored-by: Sebastian Lorenz <fubhy@fubhy.com>
effect-bot pushed a commit that referenced this pull request Jan 21, 2026
Co-authored-by: Tom MacWright <tom@macwright.com>
Co-authored-by: Sebastian Lorenz <fubhy@fubhy.com>
effect-bot pushed a commit that referenced this pull request Jan 21, 2026
Co-authored-by: Tom MacWright <tom@macwright.com>
Co-authored-by: Sebastian Lorenz <fubhy@fubhy.com>
effect-bot pushed a commit that referenced this pull request Jan 22, 2026
Co-authored-by: Tom MacWright <tom@macwright.com>
Co-authored-by: Sebastian Lorenz <fubhy@fubhy.com>
effect-bot pushed a commit that referenced this pull request Jan 22, 2026
Co-authored-by: Tom MacWright <tom@macwright.com>
Co-authored-by: Sebastian Lorenz <fubhy@fubhy.com>
effect-bot pushed a commit that referenced this pull request Jan 22, 2026
Co-authored-by: Tom MacWright <tom@macwright.com>
Co-authored-by: Sebastian Lorenz <fubhy@fubhy.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants