Skip to content

🎨 Palette: [UX improvement] Add keyboard instructions and score accessibility#163

Open
EiJackGH wants to merge 1 commit into
mainfrom
palette-mario-game-ux-15769575207908622098
Open

🎨 Palette: [UX improvement] Add keyboard instructions and score accessibility#163
EiJackGH wants to merge 1 commit into
mainfrom
palette-mario-game-ux-15769575207908622098

Conversation

@EiJackGH
Copy link
Copy Markdown
Owner

💡 What

Added a visible instruction box in the top right corner of the Mario game interface and improved the accessibility of the live score updates.

🎯 Why

  • Instructional feedback: The Mario game previously lacked any explicit indication of how to jump (Space or Up Arrow). This caused a potential friction point for users unaware of typical keyboard gaming conventions.
  • Accessibility: Live updating elements like a score count should be announced politely to screen readers, allowing visually impaired users to track their progress.

♿ Accessibility

  • Added aria-live="polite" and aria-atomic="true" to the #score element to announce point increments safely.
  • Did not hide text hints to screen readers, as instructions are vital for general interactive accessibility.

📸 Before/After

(Verified visually with Playwright snapshot: the instructions perfectly sit cleanly with a semi-transparent dark background without obstructing gameplay elements.)

Other Details

  • Fixed requirements.txt which mistakenly included venv, breaking local standard setups.

PR created automatically by Jules for task 15769575207908622098 started by @EiJackGH

… game

- Added visible `#instructions` box in the UI guiding players to use Space or Up Arrow.
- Scoped new UI elements safely within `src/views/mario-game.njk`.
- Added `aria-live="polite"` and `aria-atomic="true"` to `#score` to enhance screen reader support for dynamic game score updates.
- Removed invalid `venv` entry from `requirements.txt` to fix CI and local environment test suite setup.

Co-authored-by: EiJackGH <172181576+EiJackGH@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant