Added Target option for Start command#324
Closed
callumhutchy wants to merge 1 commit intoElectronNET:masterfrom
Closed
Added Target option for Start command#324callumhutchy wants to merge 1 commit intoElectronNET:masterfrom
callumhutchy wants to merge 1 commit intoElectronNET:masterfrom
Conversation
Uses the same structure as the /target for BuildCommand, changes the path option to follow the same system /path <path>. This allows for platform targeting when testing applications, which is necessary when using certain libraries.
callumhutchy
changed the title
Collaborator
|
@callumhutchy Sorry for the huge delay. In threory your PR looks good and makes sense, unfortunately there is a merge conflict because of recent changes. |
Author
|
@robertmuehsig I'll review this at some point over the weekend |
Contributor
|
This may help. It's what we are using with the current version of ElectronNET. |
Member
|
We use #463 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses the same structure as the /target for BuildCommand, changes the 'path' option to follow the same system /path .
Allows platform targeting when testing applications, which is necessary when using certain libraries.
Fixes #271