[Step] Use $parent.steps property instead of $parent.$children#18758
Open
Tofandel wants to merge 1 commit intoElemeFE:devfrom
Open
[Step] Use $parent.steps property instead of $parent.$children#18758Tofandel wants to merge 1 commit intoElemeFE:devfrom
Tofandel wants to merge 1 commit intoElemeFE:devfrom
Conversation
Tofandel
changed the title
Member
|
Deploy preview for element ready! Built with commit 1d301b0 |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Author
|
Bump |
Author
|
@cs1707 Can you have a look please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using
el-stepswith elements other thanel-step(To display content when vertical for instance)When the step is changed, an error is thrown (
TypeError: prevChild.calcProgress is not a function) because the element is using the$childrenproperty of the$parent(Refering to the el-step components and also the content elements that are not el-step and thus messing up the index of the$childrenproperty)The el-step element is already adding a property
stepsto it's parent and this property should be used instead of$childrenThis fixes the previously described bug
devbranch.