Dialog: only destroy slot when destroyOnClose is true#19753
Open
CeceWall wants to merge 1 commit intoElemeFE:devfrom
Open
Dialog: only destroy slot when destroyOnClose is true#19753CeceWall wants to merge 1 commit intoElemeFE:devfrom
CeceWall wants to merge 1 commit intoElemeFE:devfrom
Conversation
Member
|
Deploy preview for element ready! Built with commit d23c716 |
|
Why this fix is not accepted? |
|
Accept this fix, please |
🇵🇪
|
Is there any reason this PR has not been addressed for over 6 months? |
NoraH1to
suggested changes
Jan 26, 2022
NoraH1to
left a comment
NoraH1to
left a comment
There was a problem hiding this comment.
maybe u can move line 133~135 to afterLeave method，then the default slot will destroy after the animation ends
| this.$nextTick(() => { | ||
| this.key++; | ||
| }); | ||
| this.rendered = false; |
There was a problem hiding this comment.
maybe u can move line 133~135 to afterLeave method，then the default slot will destroy after the animation ends
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
destroyOnClose would destroy and recreate slot when dialog closed, this commit only destroy slot
devbranch.[Bug Report] destroy-on-close in el-dialog will invoke inner component's created method #18957