Skip to content

fix: scss file compile error when using dart-sass#20022

Open
roojay wants to merge 1 commit intoElemeFE:devfrom
roojay:dev
Open

fix: scss file compile error when using dart-sass#20022
roojay wants to merge 1 commit intoElemeFE:devfrom
roojay:dev

Conversation

@roojay
Copy link
Copy Markdown
Contributor

@roojay roojay commented Aug 7, 2020

当使用 dart-sass 对项目的主题文件进行编译时, 双引号会导致编译失败

elementui-scss-error

@element-bot
Copy link
Copy Markdown
Member

Deploy preview for element ready!

Built with commit 243917a

https://deploy-preview-20022--element.netlify.app

Copy link
Copy Markdown

@boomyao boomyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's ok

@storskegg
Copy link
Copy Markdown

storskegg commented Aug 21, 2020

I was just about to submit a fix to this very same issue. the same error is thrown by the underlying "sass" package, at least with 1.26.x. (node-sass seems to be more syntactically lenient re: this issue.)

@FrankCheungDev
Copy link
Copy Markdown

I wonder why this commit is not deployed yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants