Add ListPeerChannels method - #16
Merged
Merged
Conversation
Contributor
|
Curious how you tested this |
Contributor
Author
It is just adding one new method. I tested by using it to fix this issue: giovannizotta/circular#20 |
Contributor
|
Ah ok you tested it with circular? Cool, I'll try it out soon |
Contributor
Author
Thanks. Use this fork. |
Contributor
Author
|
@YusukeShimizu Hi, could you review this PR please? |
YusukeShimizu
approved these changes
Sep 10, 2024
YusukeShimizu
left a comment
YusukeShimizu
left a comment
Contributor
There was a problem hiding this comment.
Thank you for your support.
I have tested it in peerswap and confirmed that it is working correctly.
YusukeShimizu
added a commit
that referenced
this pull request
Sep 22, 2024
#16 introduced new fields to the PeerChannel struct returned by the listpeers command, but the corresponding test was not updated, causing the test build to fail. This commit fixes the test code to accommodate the changes in the PeerChannel struct, resolving the build error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CLN 24.05 removed channels list from ListPeers response. Projects that depended on it could use ListPeerChannels now.
https://docs.corelightning.org/reference/lightning-listpeerchannels