psbt: fix broken script finder in wally_finalize_psbt - #200
Merged
greenaddress merged 1 commit intoJun 2, 2020
Merged
Conversation
As written, this was looking at the output script on the global_tx for an input on the same, which caused valgrind problems because A) there's no guarantee that an output at that input index exists and also B) that's not even the right script. What you *want* to be doing is using the non_witness_utxo to look up the script iff it exists. If there's no out_script available we totally bail on finalizing this input at all.
Contributor
|
utack 5642664 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As written, this was looking at the output script on the global_tx for
an input on the same, which caused valgrind problems because A) there's
no guarantee that an output at that input index exists and also B)
that's not even the right script.
What you want to be doing is using the non_witness_utxo to look up the
script iff it exists.
If there's no out_script available we totally bail on finalizing this
input at all.