tests: enable non swig elements tests even when swig not enabled - #207
Closed
niftynei wants to merge 1 commit into
Closed
tests: enable non swig elements tests even when swig not enabled#207niftynei wants to merge 1 commit into
niftynei wants to merge 1 commit into
Conversation
too many if nests meant that the build_elements tests would only run if both elements + swig_python were enabled. here we split this into two sections, where non-swig build_elements tests will run iff build_elements is flagged.
This was referenced Jul 13, 2020
Merged
Contributor
|
Closing this in favour of #210 which includes/supersedes it. Please re-open if something you need got missed in the merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
too many if nests meant that the build_elements tests would only run if
both elements + swig_python were enabled. here we split this into two
sections, where non-swig build_elements tests will run iff build_elements is
flagged.