Review updates and PSBT changes

.gitignore

@@ -1,5 +1,6 @@
 bld
 *.pyc
+*.swp
 src/test/__pycache__/
 *~
 *.class
@@ -43,6 +44,7 @@ src/test_bech32*
 src/test_blech32*
 src/test_clear*
 src/test_tx*
+src/test_psbt*
 src/test_elements_tx*
 src/test-suite.log
 src/swig_java/swig_java_wrap.c
@@ -82,10 +84,14 @@ docs/source/core.rst
 docs/source/crypto.rst
 docs/source/psbt.rst
 docs/source/script.rst
+docs/source/symmetric.rst
 docs/source/transaction.rst
 docs/source/elements.rst
 .idea/
 
+# ctags
+tags
+
 # MacOS
 **/.DS_Store
 

CHANGES.md

@@ -1,50 +1,56 @@
 # Changes
 
+## Version 0.7.9
+
+- elements_pegout_script_from_bytes, asset_pak_whitelistproof and
+  psbt_to_bytes now follow the library convention for too-short buffers
+  instead of returning WALLY_EINVAL. See the generated API documentation
+  section "Variable Length Output Buffers" for details.
+
+- psbt_combine has been changed to only combine one PSBT into another.
+
+- psbt_to_bytes, psbt_get_length and psbt_to_base64 now take a flags argument.
+
+- FINGERPRINT_LEN was renamed to BIP32_KEY_FINGERPRINT_LEN for
+  consistency - You should change any references in your source when upgrading.
+
+- The following PSBT functions have been renamed for consistency:
+  - wally_add_new_keypath -> wally_keypath_map_add
+  - wally_add_new_partial_sig -> wally_partial_sigs_map_add
+  - wally_add_new_unknown -> wally_unknowns_map_add
+  - wally_extract_psbt -> wally_psbt_extract
+  - wally_finalize_psbt -> wally_psbt_finalize
+  - wally_sign_psbt -> wally_psbt_sign
+  - wally_combine_psbts -> wally_psbt_combine
+
 ## Version 0.7.8
 
-- Deprecate Python 2 wheels
-- Honor CFLAGS, default to O2
-- Bug fixing
+- Python 2 wheels are now deprecated. Users should move to Python 3 as soon as possible.
 
 ## Version 0.7.7
 
-- Expose wally_psbt_get_length
-- Add wally_scriptpubkey_to_address
-- Return written bytes in asset_pak_whitelistproof
-- Elements bug fixes
+- API change of wally_asset_pak_whitelistproof to return the number of bytes written.
 
 ## Version 0.7.6
 
-- Add flag to sort multisig keys (BIP67)
-- Add bip32_key_get_fingerprint
-- Add Liquid developer guide
-- Add liquid support to address_to_scriptpubkey
+- No API changes
 
 ## Version 0.7.5
 
-- Add support for P2PKH, P2SH-P2WPKH, P2WPKH address derivation from BIP32 key
-- Add support for P2KH and P2SH address parsing
-- Add support for PSBT
-- Add support for blech32
-- Add support for pegin and pegout
-- Bug fixing, build updates and improvements
+- No API changes
 
 ## Version 0.7.4
 
-- Add support for recoverable signatures
-- Generalize Elements function to use external nonces
-- Expose blinding key functions to js wrapper
-- doc improvement and bugs fixing
+- No API changes
 
 ## Version 0.7.3
 
-- Exposed ECDH, added py3.7 x86_64 linux wheels to released artifacts, updated
-  JS bindings to support latest nodejs, doc typos and bug fixing.
+- No API changes
 
 ## Version 0.7.2
 
 - API change of wally_tx_to_bytes and wally_tx_to_hex to not accept
-  WALLY_TX_FLAG_USE_ELEMENTS bit set in flags. You should remove such flag when
+  WALLY_TX_FLAG_USE_ELEMENTS set in flags. You should remove this flag when
   upgrading. This change affects elements transactions only.
 
 ## Version 0.6.5

README.md

@@ -7,7 +7,7 @@ Read the API documentation at https://wally.readthedocs.io.
 
 Note that library interfaces may change slightly while the library design matures. Please see the [CHANGES](./CHANGES.md) file to determine if the API has changed when upgrading.
 
-Please report bugs and submit patches to https://github.com/ElementsProject/libwally-core.
+Please report bugs and submit patches to [Our github repository](https://github.com/ElementsProject/libwally-core). If you wish to report a security issue, please read [Our security reporting guidelines](./SECURITY.md).
 
 [![Build Status](https://travis-ci.org/ElementsProject/libwally-core.svg?branch=master)](https://travis-ci.org/ElementsProject/libwally-core)
 
@@ -149,8 +149,22 @@ should format your changes using [uncrustify](https://github.com/uncrustify/uncr
 version 0.60 or later. The script `./tools/uncrustify` will reformat all C
 sources in the library as needed, with the currently chosen uncrustify options.
 
+To reformat a single source file, use e.g.:
+```
+$ ./tools/uncrustify src/transaction.c
+```
+
+Or to reformat all source files, pass no arguments:
+```
+$ ./tools/uncrustify
+```
+
 You should also make sure the existing tests pass and if possible write tests
-covering any new functionality, following the existing style.
+covering any new functionality, following the existing style. You can run the
+tests via:
+```
+$ make check
+```
 
 ## Generating a coverage report
 
@@ -159,15 +173,15 @@ To generate an HTML coverage report, install `lcov` and use:
 ```
 $ ./tools/cleanup.sh
 $ ./tools/autogen.sh
-$ ./configure --enable-debug --enable-export-all --enable-swig-python --enable-swig-java --enable-coverage
+$ ./configure --enable-debug --enable-export-all --enable-swig-python --enable-swig-java --enable-js_wrappers --enable-coverage
 $ make
 $ ./tools/coverage.sh clean
 $ make check
 $ ./tools/coverage.sh
 ```
 
-The coverage report can then be viewed at `src/lcov/index.html`. Patches to
-increase the test coverage are welcome.
+The coverage report can then be viewed at `./src/lcov/src/index.html`. Patches
+to increase the test coverage are welcome.
 
 ## Users of libwally-core