Configurator cross fix - #1102
Merged
cdecker merged 3 commits intoFeb 26, 2018
Merged
Conversation
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
…URATOR_CC This should solve what @icota wanted in ElementsProject#1035 in a much cleaner way. In particular, this allows you to say what configurator should use, independent of what other compilation should use, and reverts the '-static' which broke MacOS. Fixes: ElementsProject#1059 Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This way if the argument change, it will be regenerated. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Contributor
|
Looks OK to me, would ACK, but deferring to the affected users. |
Contributor
|
ACK |
Contributor
|
ACK Gotta have that |
Contributor
|
I was able to run |
Member
|
ACK e9a35f5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my preferred fix for #1090. @icota @arowser @Sjors ?